[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #151: [MNG-5222] Improvement in deprecated params detection

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151#discussion_r851620420


##########
core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/DeprecatedConfigMojo.java:
##########
@@ -47,6 +48,18 @@
     @Parameter( defaultValue = "${basedir}", readonly = true )
     private File basedir;
 
+    /**
+     * @deprecated bean read only
+     */
+    @Parameter(  defaultValue = "${project.artifact}", readonly = true )
+    private Artifact deprecatedBeanReadOnly;
+
+    /**
+     * @deprecated bean
+     */
+    @Parameter(  defaultValue = "${project.artifact}" )
+    private Artifact deprecatedBean;

Review Comment:
   I don't see the corresponding test...



##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5222MojoDeprecatedParamsTest.java:
##########
@@ -35,7 +35,7 @@
 {
     public MavenITmng5222MojoDeprecatedParamsTest()
     {
-        super( "[3.9.0,)" );
+        super( "[4.0.0-alpha-1,)" );

Review Comment:
   Why back to 4 and not with 3.9?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org