You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2019/11/08 03:12:08 UTC

[james-project] 21/36: PROTOCOLS-37 [Refactoring] AbstractProtocolTransport::writeQueuedResponses is no longer used

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 2cf0c2fe8659ea39e171f6abb419483918f61ffe
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu Nov 7 09:05:27 2019 +0700

    PROTOCOLS-37 [Refactoring] AbstractProtocolTransport::writeQueuedResponses is no longer used
---
 .../protocols/api/AbstractProtocolTransport.java   | 29 ----------------------
 1 file changed, 29 deletions(-)

diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
index aa06d99..df4f478 100644
--- a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
+++ b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractProtocolTransport.java
@@ -61,35 +61,6 @@ public abstract class AbstractProtocolTransport implements ProtocolTransport {
     }
     
     /**
-     * Helper method which tries to write all queued {@link Response}'s to the remote client. This method makes sure the {@link Response}'s are written
-     * in the correct order
-     * 
-     * This is related to PROTOCOLS-36
-     * 
-     * @param session
-     */
-    private  void writeQueuedResponses(ProtocolSession session) {
-        
-        // dequeue Responses until non is left
-        while (true) {
-            
-            Response queuedResponse = null;
-            
-            // synchrnously we check responses and if it is empty we move back to non asynch
-            // behaviour
-            synchronized (this) {
-                queuedResponse = responses.poll();
-                if (queuedResponse == null) {
-                    isAsync = false;
-                    break;
-                }
-            }
-
-            writeResponseToClient(queuedResponse, session);
-        }
-    }
-    
-    /**
      * Write the {@link Response} to the client
      * 
      * @param response


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org