You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/10/22 08:43:53 UTC

[GitHub] [tomcat] m0ver opened a new pull request, #560: Avoid the unnecessary parsing for web xml as it equals NoDefaultWebXml.

m0ver opened a new pull request, #560:
URL: https://github.com/apache/tomcat/pull/560

   If the defaultWebXml is not null and equals NoDefaultWebXml, then no need to proceed the web xml configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf closed pull request #560: Avoid the unnecessary parsing for web xml as it equals NoDefaultWebXml.

Posted by GitBox <gi...@apache.org>.
markt-asf closed pull request #560: Avoid the unnecessary parsing for web xml as it equals NoDefaultWebXml.
URL: https://github.com/apache/tomcat/pull/560


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[GitHub] [tomcat] markt-asf commented on pull request #560: Avoid the unnecessary parsing for web xml as it equals NoDefaultWebXml.

Posted by GitBox <gi...@apache.org>.
markt-asf commented on PR #560:
URL: https://github.com/apache/tomcat/pull/560#issuecomment-1288090495

   This is not correct. No default web.xml does not mean no web.xml. The correct check is already in place in `getGlobalWebXmlSource()`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org