You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 03:35:56 UTC
[PR] test(common): deepen EntityIds parsing coverage [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3267:
URL: https://github.com/apache/rocketmq-dashboard/pull/3267
## Summary
Extends the existing `EntityIdsTest` (2 to 5 tests) to pin down the external-string-to-primary-key conversion used across the persistence API boundary.
Added cases:
- blank and null identifiers are rejected with the `id is required` 400 error;
- non-numeric identifiers (letters, decimals, suffixes, hex prefixes, and values overflowing `long`) are rejected with the `numeric value` 400 error that echoes the offending value;
- signed (`+7`) and zero-padded (`007`) identifiers parse to the expected key, and values above 32-bit range are preserved (`2147483648`).
## Why
Every entity id arriving as an API string is converted here, so the exact 400 contract shapes client error handling; only trimming and zero/negative cases were covered before.
## Testing
`mvn -B test -Dtest=EntityIdsTest` — 5/5 pass; checkstyle (validate) clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(common): deepen EntityIds parsing coverage [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3267: test(common): deepen EntityIds parsing coverage
URL: https://github.com/apache/rocketmq-dashboard/pull/3267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org