You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Gregory Chanan (JIRA)" <ji...@apache.org> on 2012/05/17 21:24:07 UTC
[jira] [Created] (HBASE-6038) Add getClusterStatus PB-based call to
HMasterInterface
Gregory Chanan created HBASE-6038:
-------------------------------------
Summary: Add getClusterStatus PB-based call to HMasterInterface
Key: HBASE-6038
URL: https://issues.apache.org/jira/browse/HBASE-6038
Project: HBase
Issue Type: Task
Components: ipc, master, migration, regionserver
Reporter: Gregory Chanan
Assignee: Gregory Chanan
Fix For: 0.96.0
This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6038) Add getClusterStatus PB-based call to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6038:
----------------------------------
Attachment: HBASE-6038.patch
* Attached HBASE-6038.patch *
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6038) Add getClusterStatus PB-based call
to HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289980#comment-13289980 ]
Gregory Chanan commented on HBASE-6038:
---------------------------------------
There's a little. I wanted the hbase version and clusterId classes for the ClusterStatus proto. Those were under /src/protobuf and I couldn't seem to access them from /src/main/protobuf (where I had originally put the ClusterStatus) stuff. So it seemed to make sense to just move them.
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6038) Add getClusterStatus PB-based call to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6038:
----------------------------------
Status: Patch Available (was: Open)
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6038) Add getClusterStatus PB-based call
to HMasterInterface
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289824#comment-13289824 ]
Hadoop QA commented on HBASE-6038:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12531006/HBASE-6038.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.TestRegionRebalancing
org.apache.hadoop.hbase.client.TestFromClientSide
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2111//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2111//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2111//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2111//console
This message is automatically generated.
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6038) Add getClusterStatus PB-based call to
HMasterInterface
Posted by "Gregory Chanan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Chanan updated HBASE-6038:
----------------------------------
Attachment: HBASE-6038v2.patch
* Attached HBASE-6038v2.patch *
Same version of patch, but properly --no-prefix (ed).
I also was unable to reproduce the unit test failures when I ran them locally.
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6038) Add getClusterStatus PB-based call
to HMasterInterface
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289883#comment-13289883 ]
Hadoop QA commented on HBASE-6038:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12531045/HBASE-6038v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
org.apache.hadoop.hbase.master.TestSplitLogManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2113//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2113//console
This message is automatically generated.
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6038) Add getClusterStatus PB-based call
to HMasterInterface
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290081#comment-13290081 ]
Hudson commented on HBASE-6038:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #43 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/43/])
HBASE-6038 Add getClusterStatus PB-based call to HMasterInterface (Revision 1346748)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ClusterStatus.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HServerLoad.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClusterStatusProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/MasterProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
* /hbase/trunk/hbase-server/src/main/protobuf/ClusterId.proto
* /hbase/trunk/hbase-server/src/main/protobuf/ClusterStatus.proto
* /hbase/trunk/hbase-server/src/main/protobuf/FS.proto
* /hbase/trunk/hbase-server/src/main/protobuf/Master.proto
* /hbase/trunk/hbase-server/src/protobuf/ClusterId.proto
* /hbase/trunk/hbase-server/src/protobuf/FS.proto
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6038) Add getClusterStatus PB-based call
to HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289975#comment-13289975 ]
stack commented on HBASE-6038:
------------------------------
Patch looks good Gregory. Is there some of hbase-6000 in here? Is that intentional?
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6038) Add getClusterStatus PB-based call to
HMasterInterface
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6038:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Gregory.
> Add getClusterStatus PB-based call to HMasterInterface
> ------------------------------------------------------
>
> Key: HBASE-6038
> URL: https://issues.apache.org/jira/browse/HBASE-6038
> Project: HBase
> Issue Type: Task
> Components: ipc, master, migration, regionserver
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6038.patch, HBASE-6038v2.patch
>
>
> This should be a subtask of HBASE-5445, but since that is a subtask, I can't also make this a subtask (apparently).
> public ClusterStatus getClusterStatus();
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira