You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/10/10 05:05:48 UTC
[GitHub] [fineract] tapaswenipathak opened a new pull request, #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
tapaswenipathak opened a new pull request, #2642:
URL: https://github.com/apache/fineract/pull/2642
Ref: https://github.com/openMF/mifos-documentation/issues/14.
cc @edcable.
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
URL: https://github.com/apache/fineract/pull/2642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] tapaswenipathak commented on a diff in pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
Posted by GitBox <gi...@apache.org>.
tapaswenipathak commented on code in PR #2642:
URL: https://github.com/apache/fineract/pull/2642#discussion_r991834962
##########
fineract-doc/src/docs/en/chapters/architecture/design.adoc:
##########
@@ -40,3 +40,31 @@ NOTE: if a RollbackTransactionAsCommandIsNotApprovedByCheckerException occurs at
* Process command using handler (In transactional scope).
* CommandSource object created/updated with all details for logging to 'm_portfolio_command_source' table.
* In update scenario, we check to see if there where really any changes/updates. If so only JSON for changes is stored in audit log.
+
+= Instance Types Configuring Capabilities to Fineract
Review Comment:
cc @edcable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2642:
URL: https://github.com/apache/fineract/pull/2642#discussion_r991451317
##########
fineract-doc/src/docs/en/chapters/architecture/design.adoc:
##########
@@ -40,3 +40,31 @@ NOTE: if a RollbackTransactionAsCommandIsNotApprovedByCheckerException occurs at
* Process command using handler (In transactional scope).
* CommandSource object created/updated with all details for logging to 'm_portfolio_command_source' table.
* In update scenario, we check to see if there where really any changes/updates. If so only JSON for changes is stored in audit log.
+
+= Instance Types Configuring Capabilities to Fineract
Review Comment:
Not sure what this is. The instance type support is already explained: https://fineract.apache.org/docs/current/#_fineract_instance_types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2642: Refinement to existing documentation on the enhanced ability to separate read/write/batch API operations for greater performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #2642:
URL: https://github.com/apache/fineract/pull/2642#issuecomment-1311070037
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org