You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/19 18:51:46 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #366: Change 'breaking change' label to 'api change'
alamb opened a new pull request #366:
URL: https://github.com/apache/arrow-datafusion/pull/366
# Rationale for this change
I find "breaking" to have a negative connotation. Let's change it to be 'api change' rather than 'breaking 'c
# What changes are included in this PR?
Change label name used for API changes from "breaking change" to "api change"
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #366: Change 'breaking change' label to 'api change'
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #366:
URL: https://github.com/apache/arrow-datafusion/pull/366#issuecomment-844390334
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#366](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1f620e) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/2f73558b6ed68974f2b63d64bef4628b0776d3d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f73558) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 143 143
Lines 23773 23773
=======================================
Hits 18041 18041
Misses 5732 5732
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f73558...b1f620e](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #366: Change 'breaking change' label to 'api change'
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #366:
URL: https://github.com/apache/arrow-datafusion/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter edited a comment on pull request #366: Change 'breaking change' label to 'api change'
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #366:
URL: https://github.com/apache/arrow-datafusion/pull/366#issuecomment-844390334
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#366](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (95aef67) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/2f73558b6ed68974f2b63d64bef4628b0776d3d5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f73558) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 95aef67 differs from pull request most recent head b1f620e. Consider uploading reports for the commit b1f620e to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 75.88% 75.88%
=======================================
Files 143 143
Lines 23773 23773
=======================================
Hits 18041 18041
Misses 5732 5732
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2f73558...b1f620e](https://codecov.io/gh/apache/arrow-datafusion/pull/366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #366: Change 'breaking change' label to 'api change'
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #366:
URL: https://github.com/apache/arrow-datafusion/pull/366#issuecomment-847019225
FYI @andygrove / @jorgecarleitao / @nevi-me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org