[GitHub] [cassandra-accord] bdeggleston commented on a diff in pull request #38: CASSANDRA-18364: CEP-15: (C*) Accord message processing should avoid being passed on to a Stage and run directly in the messageing handler

["bdeggleston (via GitHub)" <gi...@apache.org>]

bdeggleston commented on code in PR #38:
URL: https://github.com/apache/cassandra-accord/pull/38#discussion_r1156191589


##########
accord-core/src/main/java/accord/api/MessageSink.java:
##########
@@ -27,6 +28,6 @@
 public interface MessageSink
 {
     void send(Id to, Request request);
-    void send(Id to, Request request, Callback callback);
+    void send(Id to, Request request, CommandStore commandStore, Callback callback);

Review Comment:
   Should `CommandStore` be added to the callback interface?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org