You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nicholas Knize (JIRA)" <ji...@apache.org> on 2015/06/15 17:37:00 UTC
[jira] [Comment Edited] (LUCENE-6547) Add dateline crossing support
to GeoPointInBBox and GeoPointDistance Queries
[ https://issues.apache.org/jira/browse/LUCENE-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586191#comment-14586191 ]
Nicholas Knize edited comment on LUCENE-6547 at 6/15/15 3:36 PM:
-----------------------------------------------------------------
Updated patch to include review feedback from [~mikemccand]:
* Added back validation check for lat/lons passed to GeoPointInBBoxQuery.
* Reverted changes made to GeoPointInPolygonQuery.
* Changed GeoPointTermsEnum.min/maxLat back to final
* Changed dateline split logic for GeoPointInBBox and GeoPointDistance query to rewrite using BQ SHOULD.
* Keeping circleToPoly utility method, for now, for testing PointInPolygon query performance (this can maybe go away later?)
* Updated GeoPointDistanceQuery javadocs
bq. Can we fix the random test to more strongly separate out the cases its testing?
Will get this in either the next iteration, or maybe a separate 'improve GeoPointField Testing' issue?
was (Author: nknize):
Updated patch to include review feedback from [~mikemccand]:
* Added back validation check for lat/lons passed to GeoPointInBBoxQuery.
* Reverted changes made to GeoPointInPolygonQuery.
* Changed GeoPointTermsEnum.min/maxLat back to final
* Changed dateline split logic for GeoPointInBBox and GeoPointDistance query to rewrite using BQ SHOULD.
* Keeping circleToPoly utility method, for now, for testing PointInPolygon query performance (this can maybe go away later?)
* Updated GeoPointDistanceQuery javadocs
bq. Can we fix the random test to more strongly separate out the cases its
testing?
Will get this in either the next iteration, or maybe a separate 'improve GeoPointField Testing' issue?
> Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
> ----------------------------------------------------------------------------
>
> Key: LUCENE-6547
> URL: https://issues.apache.org/jira/browse/LUCENE-6547
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Nicholas Knize
> Attachments: LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch
>
>
> The current GeoPointInBBoxQuery only supports bounding boxes that are within the standard -180:180 longitudinal bounds. While its perfectly fine to require users to split dateline crossing bounding boxes in two, GeoPointDistanceQuery should support distance queries that cross the dateline. Since morton encoding doesn't support unwinding this issue will add dateline crossing to GeoPointInBBoxQuery and GeoPointDistanceQuery classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org