You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/12/15 20:24:31 UTC
[jira] [Commented] (HIVE-2544) Nullpointer on registering udfs.
[ https://issues.apache.org/jira/browse/HIVE-2544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13170431#comment-13170431 ]
jiraposter@reviews.apache.org commented on HIVE-2544:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2702/#review3927
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8870>
Is it possible to write a test case, which spins 10s of threads doing operations. Thats not fool-proof but will result in some coverage. Unless you have a better idea for writing test case for this.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2702/#comment8869>
Its LinkedHashMap right now, changing it to Concurrent will violate the contract of LinkedHashMap which you can iterate in same order as your inserts. Not sure if violating that is alright here.
- Ashutosh
On 2011-11-03 13:47:48, Bennie Schut wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2702/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-03 13:47:48)
bq.
bq.
bq. Review request for hive.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. HIVE-2544: Nullpointer on registering udfs.
bq.
bq.
bq. This addresses bug HIVE-2544.
bq. https://issues.apache.org/jira/browse/HIVE-2544
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1196618
bq.
bq. Diff: https://reviews.apache.org/r/2702/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Bennie
bq.
bq.
> Nullpointer on registering udfs.
> --------------------------------
>
> Key: HIVE-2544
> URL: https://issues.apache.org/jira/browse/HIVE-2544
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 0.9.0
> Reporter: Bennie Schut
> Assignee: Bennie Schut
> Fix For: 0.9.0
>
> Attachments: HIVE-2544.1.patch.txt
>
>
> Currently the Function registry can throw NullPointers when multiple threads are trying to register the same function. The normal put() will replace the existing registered function object even if it's exactly the same function.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira