You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/15 13:16:49 UTC
[GitHub] [flink] HuangXingBo opened a new pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
HuangXingBo opened a new pull request #13652:
URL: https://github.com/apache/flink/pull/13652
## What is the purpose of the change
*This pull request will merge pyflink table and dastream e2e tests*
## Brief change log
- *merge pyflink table and dastream e2e tests*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f05970c4fc407a89e90d7fc685419a68cdaaa50 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
}, {
"hash" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7718",
"triggerID" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acc3600f07bd59ca353d2cce8eb5bfbe008a7f11 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709321441
Thanks a lot for addressing this so quickly. The change looks good at first glance. Let's see how much e2e time improvement we get from this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709567753
Could you rebase to latest master? then the e2e tests will pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] HuangXingBo commented on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
HuangXingBo commented on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709709350
@rmetzger Thanks a lot. I have rebase the master and push again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709319332
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 3f05970c4fc407a89e90d7fc685419a68cdaaa50 (Thu Oct 15 13:19:34 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dianfu merged pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
dianfu merged pull request #13652:
URL: https://github.com/apache/flink/pull/13652
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f05970c4fc407a89e90d7fc685419a68cdaaa50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
}, {
"hash" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7718",
"triggerID" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f05970c4fc407a89e90d7fc685419a68cdaaa50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694)
* acc3600f07bd59ca353d2cce8eb5bfbe008a7f11 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
}, {
"hash" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acc3600f07bd59ca353d2cce8eb5bfbe008a7f11",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f05970c4fc407a89e90d7fc685419a68cdaaa50 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694)
* acc3600f07bd59ca353d2cce8eb5bfbe008a7f11 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13652: [FLINK-19654][python][e2] merge pyflink table and dastream e2e tests
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13652:
URL: https://github.com/apache/flink/pull/13652#issuecomment-709336832
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694",
"triggerID" : "3f05970c4fc407a89e90d7fc685419a68cdaaa50",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3f05970c4fc407a89e90d7fc685419a68cdaaa50 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=7694)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org