[GitHub] sijie commented on a change in pull request #737: Update `protobuf/README.md`

[gi...@git.apache.org]

sijie commented on a change in pull request #737: Update `protobuf/README.md`
URL: https://github.com/apache/incubator-pulsar/pull/737#discussion_r136470368
 
 

 ##########
 File path: protobuf/README.md
 ##########
 @@ -17,28 +17,16 @@ To re-generate the `PulsarApi.java` code you need to apply a patch to the protob
 
 The pre-generated C++ code is at `pulsar-client-cpp/lib/PulsarApi.pb.cc` and `pulsar-client-cpp/lib/PulsarApi.pb.h`.
 
-### Commands for creating the pre-generated files
+You don't need to manually generate C++ code. The C++ code is automatically generated by `cmake`.
+
+### Commands for creating the pre-generated Java code
 
 ```shell
 export PULSAR_HOME=<Path where you cloned the pulsar repo>
 
 cd $HOME
 git clone https://github.com/google/protobuf.git
 
-### For C++ ###
-cd ${HOME}/protobuf
-git checkout v2.6.0
-
-### Compile protobuf
-autoreconf --install
-./configure
-make
-
-### Re-generate PulsarApi
-cd ${PULSAR_HOME}/pulsar-client-cpp/
-export PROTOC=${HOME}/protobuf/src/protoc 
-./generate_protobuf.sh
-
 ### For Java ###
 
 Review comment:
   done
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services