You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/11/17 23:46:40 UTC
[kudu-CR] [cfile] 'null bitmap' --> 'non-null bitmap'
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22075
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap'
......................................................................
[cfile] 'null bitmap' --> 'non-null bitmap'
The corresponding bitmaps have always had the semantics that a set bit
indicated a non-null entry. Thus naming any of those as a 'null bitmap'
is quite misleading. Also, since changelist [1] renamed a subset of
entities already, now it's even more confusing.
I think it's never too late to add more clarity, so this patch renames
the rest of the entities in the code and also updates the documentation.
This patch doesn't contain any functional modifications.
This is a follow-up to [1].
[1] https://github.com/apache/kudu/commit/ffef96b26
Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
---
M docs/design-docs/cfile.md
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/columnblock.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/rowblock.h
10 files changed, 46 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/22075/1
--
To view, visit http://gerrit.cloudera.org:8080/22075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Gerrit-Change-Number: 22075
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [cfile] 'null bitmap' --> 'non-null bitmap'
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22075 )
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap'
......................................................................
[cfile] 'null bitmap' --> 'non-null bitmap'
The corresponding bitmaps have always had the semantics that a set bit
indicated a non-null entry. Thus naming any of those as a 'null bitmap'
is quite misleading. Also, since changelist [1] renamed a subset of
entities already, now it's even more confusing.
I think it's never too late to add more clarity, so this patch renames
the rest of the entities in the code and also updates the documentation.
This patch doesn't contain any functional modifications.
This is a follow-up to [1].
[1] https://github.com/apache/kudu/commit/ffef96b26
Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Reviewed-on: http://gerrit.cloudera.org:8080/22075
Tested-by: Kudu Jenkins
Reviewed-by: Yifan Zhang <ch...@163.com>
---
M docs/design-docs/cfile.md
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_util.cc
M src/kudu/cfile/cfile_writer.cc
M src/kudu/cfile/cfile_writer.h
M src/kudu/common/columnar_serialization.cc
M src/kudu/common/columnblock.h
M src/kudu/common/row_operations.cc
M src/kudu/common/row_operations.h
M src/kudu/common/rowblock.h
10 files changed, 46 insertions(+), 40 deletions(-)
Approvals:
Kudu Jenkins: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Gerrit-Change-Number: 22075
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] [cfile] 'null bitmap' --> 'non-null bitmap'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22075 )
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap'
......................................................................
Patch Set 1: Verified+1
Build Successful
http://jenkins.kudu.apache.org/job/pre_commit/683/ : SUCCESS
--
To view, visit http://gerrit.cloudera.org:8080/22075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Gerrit-Change-Number: 22075
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 00:41:28 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] 'null bitmap' --> 'non-null bitmap'
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22075 )
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap'
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Gerrit-Change-Number: 22075
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Mon, 18 Nov 2024 07:53:41 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] 'null bitmap' --> 'non-null bitmap'
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22075 )
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap'
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/683/
--
To view, visit http://gerrit.cloudera.org:8080/22075
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604
Gerrit-Change-Number: 22075
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 17 Nov 2024 23:46:46 +0000
Gerrit-HasComments: No