You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cloudstack.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2014/12/05 23:31:13 UTC

[jira] [Commented] (CLOUDSTACK-7195) security_group.py should log exceptions instead of discarding them

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236230#comment-14236230 ] 

ASF subversion and git services commented on CLOUDSTACK-7195:
-------------------------------------------------------------

Commit 3ea8a1187a825fdbcf7f78198afc00a2f3a8b974 in cloudstack's branch refs/heads/master from [~vbernat]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3ea8a11 ]

CLOUDSTACK-7195: log wide exceptions in security_group.py

Some try/except in security_group.py catch a lot of exceptions. There
was already one fixed in CLOUDSTACK-1052. Here is another one. We use
logging.exception() to log those exceptions.

Signed-off-by: Vincent Bernat <Vi...@exoscale.ch>
Signed-off-by: Pierre-Luc Dion <pd...@apache.org>


> security_group.py should log exceptions instead of discarding them
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-7195
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-7195
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM
>    Affects Versions: 4.3.0
>            Reporter: Vincent Bernat
>            Assignee: Pierre-Luc Dion
>
> security_group.py discards exceptions with a vague message. This is troublesome and hide some other bugs. See for example CLOUDSTACK-7193. Any try/except should at least log the exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)