You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "Copilot (via GitHub)" <gi...@apache.org> on 2025/07/02 10:08:00 UTC

Re: [PR] Enhance test 'capture error from spark process builder' for Spark 4.0 [kyuubi]

Copilot commented on code in PR #7112:
URL: https://github.com/apache/kyuubi/pull/7112#discussion_r2179664418


##########
kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala:
##########
@@ -79,7 +79,9 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
     eventually(timeout(90.seconds), interval(500.milliseconds)) {
       val error1 = processBuilder1.getError
       assert(
-        error1.getMessage.contains("org.apache.hadoop.hive.ql.metadata.HiveException:"))
+        error1.getMessage.contains("org.apache.hadoop.hive.ql.metadata.HiveException:") ||
+          error1.getMessage.contains("Unable to instantiate " +
+            "org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient"))

Review Comment:
   [nitpick] Combine the split string literal into one for readability, e.g., `error1.getMessage.contains("Unable to instantiate org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient")`.
   ```suggestion
             error1.getMessage.contains("Unable to instantiate org.apache.hadoop.hive.ql.metadata.SessionHiveMetaStoreClient"))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org