[GitHub] [skywalking-infra-e2e] kezhenxu94 commented on a change in pull request #47: Support profile to export environments

[GitBox <gi...@apache.org>]

kezhenxu94 commented on a change in pull request #47:
URL: https://github.com/apache/skywalking-infra-e2e/pull/47#discussion_r716561346



##########
File path: internal/components/setup/compose.go
##########
@@ -67,7 +68,17 @@ func ComposeSetup(e2eConfig *config.E2EConfig) error {
 		return fmt.Errorf("bind wait ports error: %v", err)
 	}
 
-	execError := compose.WithCommand([]string{"up", "-d"}).Invoke()
+	// build command
+	cmd := make([]string, 0)
+	if e2eConfig.Setup.InitSystemEnvironment != "" {
+		profilePath := util.ResolveAbs(e2eConfig.Setup.InitSystemEnvironment)
+		cmd = append(cmd, "--env-file", profilePath)
+		util.ExportEnvVars(profilePath)

Review comment:
       You've already added it to the command option, why you need to export it ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org