[GitHub] [beam] satybald commented on a change in pull request #16156: [BEAM-13391] Fix temporary file format in WriteToBigQuery

[GitBox <gi...@apache.org>]

satybald commented on a change in pull request #16156:
URL: https://github.com/apache/beam/pull/16156#discussion_r768941900



##########
File path: sdks/python/apache_beam/io/gcp/bigquery_write_it_test.py
##########
@@ -368,9 +376,9 @@ def test_big_query_write_temp_table_append_schema_update(self):
     table_id = '{}.{}'.format(self.dataset_id, table_name)
 
     input_data = [{
-        "int64": num, "bool": True, "nested_field": {
+        "int64": num, "bool": True, "nested_field": [{
             "fruit": "Apple"
-        }
+        }]

Review comment:
       it used to be a JSON format only. JSON writer is less restrictive on that case. When I've added AVRO then found that `fastavro` requires dicts be surrounded by list
   
   https://github.com/fastavro/fastavro/issues/254#issuecomment-819038448




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org