[GitHub] [solr] gerlowskija edited a comment on pull request #81: SOLR-15351: Convert /v2/c/ APIs to POJO impl

[GitBox <gi...@apache.org>]

gerlowskija edited a comment on pull request #81:
URL: https://github.com/apache/solr/pull/81#issuecomment-860611843


   > BTW I would have reviewed if you prompted me. It was on the back of my mind already.
   
   Oh, my bad.  I thought about pinging you, but didn't want to be a bother (I'd tagged you once already in a recent comment, and didn't want to push it.)  It's never too late though - if there's anything you're particularly concerned about lmk and I can take a look.
   
   > In these source files, why did you declare constants ... Referenced only in the command annotation
   
   There's only one usage _right now_, but there's likely to be other places where this string will be used eventually as v2 support progresses.  Additional tests might use it, SolrJ will need to use it to make v2 requests at some point, etc.  So to the extent I thought about it at all, that was probably my motivation.  If you know for certain that something will only ever be used once - definitely agree the constant is useless.  But in practice I rarely ever feel like I _know_ that, and in this case there's particular reason to expect additional usages in the future.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org