You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/16 16:19:11 UTC
[GitHub] [tvm] Lunderberg opened a new pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Lunderberg opened a new pull request #10272:
URL: https://github.com/apache/tvm/pull/10272
These are required for compatibility with C++14, and resolve a link-time error that was observed in debug builds on `g++-10`. For release builds, the external linkage was optimized out, so the link-time error was avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] hgt312 commented on pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
hgt312 commented on pull request #10272:
URL: https://github.com/apache/tvm/pull/10272#issuecomment-1041886211
Good catch! Due to the error, fail to build on OSX today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10272:
URL: https://github.com/apache/tvm/pull/10272#issuecomment-1042138602
Closing, duplicate of #10262.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg closed pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
Lunderberg closed pull request #10272:
URL: https://github.com/apache/tvm/pull/10272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10272:
URL: https://github.com/apache/tvm/pull/10272#issuecomment-1042086976
cc @manupa-arm also https://github.com/apache/tvm/pull/10147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] manupa-arm commented on pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
manupa-arm commented on pull request #10272:
URL: https://github.com/apache/tvm/pull/10272#issuecomment-1042118978
Should we take in #10262 instead @Lunderberg ?
cc : @electriclilies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10272: [Bugfix] Added definition for constexpr char* PoolInfo variables.
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on pull request #10272:
URL: https://github.com/apache/tvm/pull/10272#issuecomment-1042122406
No strong preferences from me either way. #10262 is consistent with how string constants are defined elsewhere in TVM, but my preference is to keep them close to the context where they're used.
Since this one is still waiting on CI, I'd go with #10262 and closing #10272.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org