[GitHub] [hbase] apurtell commented on a change in pull request #248: HBASE-22459 Expose store reader reference count

[GitBox <gi...@apache.org>]

apurtell commented on a change in pull request #248: HBASE-22459 Expose store reader reference count
URL: https://github.com/apache/hbase/pull/248#discussion_r287066775
 
 

 ##########
 File path: hbase-protocol-shaded/src/main/protobuf/ClusterStatus.proto
 ##########
 @@ -146,6 +146,9 @@ message RegionLoad {
 
   /** the current total coprocessor requests made to region */
   optional uint64 cp_requests_count = 20;
+
+  /** the number of references active on the store */
+  optional int32 store_ref_count = 21 [default = 0];
 
 Review comment:
   Reference count may go negative. It would be a bad bug. We want to see it. I know you can guess if a really large value means a negative integer was cast to unsigned but it should be explicit if it goes negative. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services