You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/11/09 07:29:21 UTC
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/19706
[SPARK-22476][R] Add dayofweek function to R
## What changes were proposed in this pull request?
This PR adds `dayofweek` to R API:
```r
data <- list(list(d = as.Date("2012-12-13")),
list(d = as.Date("2013-12-14")),
list(d = as.Date("2014-12-15")))
df <- createDataFrame(data)
collect(select(df, dayofweek(df$d)))
```
```
dayofweek(d)
1 5
2 7
3 2
```
## How was this patch tested?
Manual tests and unit tests in `R/pkg/tests/fulltests/test_sparkSQL.R`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark add-dayofweek
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19706
----
commit d24a89b6a756457c651d0c208ccbe59b979e9ecc
Author: hyukjinkwon <gu...@gmail.com>
Date: 2017-11-08T11:31:35Z
Add support for dayofweek function in R
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19706
Thanks for review @felixcheung. BTW, looks AppVeyor was failed by a different reason .. ?
```
> packageVersion('knitr'); packageVersion('rmarkdown'); packageVersion('testthat'); packageVersion('e1071'); packageVersion('survival')
Error in packageVersion("knitr") : package 'knitr' not found
Execution halted
Command exited with code 1
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19706
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19706
Thank you @felixcheung and @dongjoon-hyun for review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/spark/pull/19706
[SPARK-22476][R] Add dayofweek function to R
## What changes were proposed in this pull request?
This PR adds `dayofweek` to R API:
```r
data <- list(list(d = as.Date("2012-12-13")),
list(d = as.Date("2013-12-14")),
list(d = as.Date("2014-12-15")))
df <- createDataFrame(data)
collect(select(df, dayofweek(df$d)))
```
```
dayofweek(d)
1 5
2 7
3 2
```
## How was this patch tested?
Manual tests and unit tests in `R/pkg/tests/fulltests/test_sparkSQL.R`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark add-dayofweek
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19706
----
commit d24a89b6a756457c651d0c208ccbe59b979e9ecc
Author: hyukjinkwon <gu...@gmail.com>
Date: 2017-11-08T11:31:35Z
Add support for dayofweek function in R
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/spark/pull/19706
[SPARK-22476][R] Add dayofweek function to R
## What changes were proposed in this pull request?
This PR adds `dayofweek` to R API:
```r
data <- list(list(d = as.Date("2012-12-13")),
list(d = as.Date("2013-12-14")),
list(d = as.Date("2014-12-15")))
df <- createDataFrame(data)
collect(select(df, dayofweek(df$d)))
```
```
dayofweek(d)
1 5
2 7
3 2
```
## How was this patch tested?
Manual tests and unit tests in `R/pkg/tests/fulltests/test_sparkSQL.R`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark add-dayofweek
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19706.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19706
----
commit d24a89b6a756457c651d0c208ccbe59b979e9ecc
Author: hyukjinkwon <gu...@gmail.com>
Date: 2017-11-08T11:31:35Z
Add support for dayofweek function in R
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/19706
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19706
**[Test build #83636 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83636/testReport)** for PR 19706 at commit [`d24a89b`](https://github.com/apache/spark/commit/d24a89b6a756457c651d0c208ccbe59b979e9ecc).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19706
**[Test build #83636 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83636/testReport)** for PR 19706 at commit [`d24a89b`](https://github.com/apache/spark/commit/d24a89b6a756457c651d0c208ccbe59b979e9ecc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19706
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19706
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83634/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19706
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19706
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon closed the pull request at:
https://github.com/apache/spark/pull/19706
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19706
**[Test build #83634 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83634/testReport)** for PR 19706 at commit [`d24a89b`](https://github.com/apache/spark/commit/d24a89b6a756457c651d0c208ccbe59b979e9ecc).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19706
**[Test build #83634 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83634/testReport)** for PR 19706 at commit [`d24a89b`](https://github.com/apache/spark/commit/d24a89b6a756457c651d0c208ccbe59b979e9ecc).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83636/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19706: [SPARK-22476][R] Add dayofweek function to R
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19706
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org