[GitHub] [openwhisk] ningyougang commented on a change in pull request #5098: [New Scheduler]Implement PFCInvokerServer

[GitBox <gi...@apache.org>]

ningyougang commented on a change in pull request #5098:
URL: https://github.com/apache/openwhisk/pull/5098#discussion_r604544471



##########
File path: core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/InvokerSupervision.scala
##########
@@ -175,8 +175,26 @@ class InvokerPool(childFactory: (ActorRefFactory, InvokerInstanceId) => ActorRef
     val raw = new String(bytes, StandardCharsets.UTF_8)
     PingMessage.parse(raw) match {
       case Success(p: PingMessage) =>
-        self ! p
-        invokerPingFeed ! MessageFeed.Processed
+        if (p.instance.instance < 0) {

Review comment:
       if user wants to do some zerodowntime deployment, need to disable the invoker firstly and wait invoker executed all flying activations.
   
   User can send /disable to the invoker,  in invoker backend, use the same topic name `health` to send unhealthy message via negative number of invoker.
   
   here, get the message from kafka and make the invoker to `unhealthy` and `down` finally.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org