You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/05/20 06:50:37 UTC
[GitHub] [cordova-android] ebhsgit opened a new issue #1235: Kotlin gradle version does not change with respect to GradlePluginKotlinVersion variable
ebhsgit opened a new issue #1235:
URL: https://github.com/apache/cordova-android/issues/1235
# Bug Report
## Problem
Using cordova 9.0.0, when I set `GradlePluginKotlinVersion` to 1.4.31
I get compilation error "Expecting a parameter declaration" due to trailing comma.
----
Kotlin allowed trailing comma in 1.3.70
https://youtrack.jetbrains.com/issue/KT-34743
### What is expected to happen?
Compile without error
### What does actually happen?
Unable to compile.
Error "Expecting a parameter declaration" pointing to the trailing comma
## Information
<!-- Include all relevant information that might help understand and reproduce the problem -->
```
data class Test(
val test1: String,
val test2: String,
) {
fun test(
t1: String,
t2: String,
) {
}
}
```
This code when compiled will result in error
------
After investigating, I notice that `kotlin-android-extensions-runtime` did not respect the `GradlePluginKotlinVersion` variable.
It was set to 1.3.50.
This is due to `org.jetbrains.kotlin:kotlin-gradle-plugin` being hardcoded to version 1.3.50 in `bin\templates\project\build.gradle`
### Command or Code
<!-- What command or code is needed to reproduce the problem? -->
### Environment, Platform, Device
<!-- In what environment, on what platform or on which device are you experiencing the issue? -->
### Version information
<!--
What are relevant versions you are using?
For example:
Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins
Other Frameworks: Ionic Framework and CLI version
Operating System, Android Studio, Xcode etc.
-->
## Checklist
<!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
- [ x ] I searched for existing GitHub issues
- [ x ] I updated all Cordova tooling to most recent version
- [ x ] I included all the necessary information above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on issue #1235: Kotlin gradle version does not change with respect to GradlePluginKotlinVersion variable
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1235:
URL: https://github.com/apache/cordova-android/issues/1235#issuecomment-883843423
This should have been resolved in Cordova-Android 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu closed issue #1235: Kotlin gradle version does not change with respect to GradlePluginKotlinVersion variable
Posted by GitBox <gi...@apache.org>.
erisu closed issue #1235:
URL: https://github.com/apache/cordova-android/issues/1235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org