You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2017/02/23 23:52:08 UTC
Review Request 57004: AMBARI-20158 - Host filter is missing for admin
user after upgrading to ambari 2.4.2 or above
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/
-----------------------------------------------------------
Review request for Ambari and Jaimin Jetly.
Bugs: AMBARI-20158
https://issues.apache.org/jira/browse/AMBARI-20158
Repository: ambari
Description
-------
Always show host combo search.
Merge instead of overwrite support list after loading user-pref.
Diffs
-----
ambari-web/app/config.js 6afa810
ambari-web/app/controllers/experimental.js 8b93761
ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
Diff: https://reviews.apache.org/r/57004/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
20375 passing (23s)
153 pending
Thanks,
Richard Zang
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for
admin user after upgrading to ambari 2.4.2 or above
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166613
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 11:52 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for
admin user after upgrading to ambari 2.4.2 or above
Posted by Richard Zang <rz...@hortonworks.com>.
> On Feb. 24, 2017, 1:38 a.m., Jaimin Jetly wrote:
> > ambari-web/app/controllers/experimental.js, line 38
> > <https://reviews.apache.org/r/57004/diff/1/?file=1646551#file1646551line38>
> >
> > $.merge(response, App.get('supports')) returns back the first argument passed. As a result the application behavior remains the same as it was before this patch
> >
> > Please use $.extend instead of $.merge.
$.merge is for array, will adjust to $.extend
- Richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
-----------------------------------------------------------
On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 11:52 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for
admin user after upgrading to ambari 2.4.2 or above
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166629
-----------------------------------------------------------
ambari-web/app/controllers/experimental.js (line 38)
<https://reviews.apache.org/r/57004/#comment238630>
$.merge(response, App.get('supports')) returns back the first argument passed. As a result the application behavior remains the same as it was before this patch
Please use $.extend instead of $.merge.
- Jaimin Jetly
On Feb. 23, 2017, 11:52 p.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 11:52 p.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for
admin user after upgrading to ambari 2.4.2 or above
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/#review166755
-----------------------------------------------------------
Ship it!
- Jaimin Jetly
On Feb. 24, 2017, 2:27 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57004/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 2:27 a.m.)
>
>
> Review request for Ambari and Jaimin Jetly.
>
>
> Bugs: AMBARI-20158
> https://issues.apache.org/jira/browse/AMBARI-20158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Always show host combo search.
> Merge instead of overwrite support list after loading user-pref.
>
>
> Diffs
> -----
>
> ambari-web/app/config.js 6afa810
> ambari-web/app/controllers/experimental.js 8b93761
> ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
>
> Diff: https://reviews.apache.org/r/57004/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
> All unit tests passed.
> 20375 passing (23s)
> 153 pending
>
>
> File Attachments
> ----------------
>
> AMBARI-20158-fix1.patch
> https://reviews.apache.org/media/uploaded/files/2017/02/24/67d30316-bcff-4d49-80b7-afeffe9d703a__AMBARI-20158-fix1.patch
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 57004: AMBARI-20158 - Host filter is missing for
admin user after upgrading to ambari 2.4.2 or above
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57004/
-----------------------------------------------------------
(Updated Feb. 24, 2017, 2:27 a.m.)
Review request for Ambari and Jaimin Jetly.
Bugs: AMBARI-20158
https://issues.apache.org/jira/browse/AMBARI-20158
Repository: ambari
Description
-------
Always show host combo search.
Merge instead of overwrite support list after loading user-pref.
Diffs
-----
ambari-web/app/config.js 6afa810
ambari-web/app/controllers/experimental.js 8b93761
ambari-web/app/templates/main/host/combo_search_box.hbs d54b7df
Diff: https://reviews.apache.org/r/57004/diff/
Testing
-------
Manually tested on live cluster.
All unit tests passed.
20375 passing (23s)
153 pending
File Attachments (updated)
----------------
AMBARI-20158-fix1.patch
https://reviews.apache.org/media/uploaded/files/2017/02/24/67d30316-bcff-4d49-80b7-afeffe9d703a__AMBARI-20158-fix1.patch
Thanks,
Richard Zang