You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Boris Shkolnik <bo...@apache.org> on 2016/09/15 20:55:23 UTC
Review Request 51934: reopen a Kafka system producer if send called
again
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51934/
-----------------------------------------------------------
Review request for samza.
Bugs: SAMZA-1019
https://issues.apache.org/jira/browse/SAMZA-1019
Repository: samza
Description
-------
reopen a Kafka system producer if send called again
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a
Diff: https://reviews.apache.org/r/51934/diff/
Testing
-------
manual testing.
Thanks,
Boris Shkolnik
Re: Review Request 51934: reopen a Kafka system producer if send
called again
Posted by Xinyu Liu <xi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51934/#review149131
-----------------------------------------------------------
Ship it!
Thanks for the fix!
- Xinyu Liu
On Sept. 15, 2016, 8:55 p.m., Boris Shkolnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51934/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2016, 8:55 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-1019
> https://issues.apache.org/jira/browse/SAMZA-1019
>
>
> Repository: samza
>
>
> Description
> -------
>
> reopen a Kafka system producer if send called again
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a
>
> Diff: https://reviews.apache.org/r/51934/diff/
>
>
> Testing
> -------
>
> manual testing.
>
>
> Thanks,
>
> Boris Shkolnik
>
>
Re: Review Request 51934: reopen a Kafka system producer if send
called again
Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51934/#review149156
-----------------------------------------------------------
Ship it!
Pretty Neat! :) lgtm
- Jagadish Venkatraman
On Sept. 15, 2016, 8:55 p.m., Boris Shkolnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51934/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2016, 8:55 p.m.)
>
>
> Review request for samza.
>
>
> Bugs: SAMZA-1019
> https://issues.apache.org/jira/browse/SAMZA-1019
>
>
> Repository: samza
>
>
> Description
> -------
>
> reopen a Kafka system producer if send called again
>
>
> Diffs
> -----
>
> samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a
>
> Diff: https://reviews.apache.org/r/51934/diff/
>
>
> Testing
> -------
>
> manual testing.
>
>
> Thanks,
>
> Boris Shkolnik
>
>
Re: Review Request 51934: reopen a Kafka system producer if send
called again
Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51934/
-----------------------------------------------------------
(Updated Sept. 21, 2016, 8:37 p.m.)
Review request for samza.
Bugs: SAMZA-1019
https://issues.apache.org/jira/browse/SAMZA-1019
Repository: samza
Description (updated)
-------
reopen a Kafka system producer if send called again
Closing this patch. Replacing it with 52133.
Diffs
-----
samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemProducer.scala 5ff6d3caf54ed148aa40c7c752c587e556a4f34a
Diff: https://reviews.apache.org/r/51934/diff/
Testing
-------
manual testing.
Thanks,
Boris Shkolnik