You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/07 23:41:22 UTC

[GitHub] [incubator-mxnet] barry-jin edited a comment on pull request #20474: [FEATURE] Enable dynamic linking with MKL and compiler based OpenMP

barry-jin edited a comment on pull request #20474:
URL: https://github.com/apache/incubator-mxnet/pull/20474#issuecomment-938204263


   > Now it seems the change seems to be tested and checked for MacOS and with MKL BLAS.
   > Do you think that leaving that new github action for MKL on MacOS make sense? If so, can it look as it is or change it somehow?
   
   Yes, we need to keep this new github action as it will cover MKL related build and tests on MacOS. 
   
   > Remark: I see that windows-gpu fails, but it's rather not connected with that change but maybe with the VS 2019 version 16.11 Release? As I see that for v16.8.1 (MSVC 19.28.29333.0) it passed without any issues, while for v16.11.4 (MSVC 19.29.30136.0) it fails. But I'm not 100% sure. 
   
   I have created a pull request #20647  to try to fix it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org