[GitHub] [guacamole-client] necouchman commented on pull request #505: GUACAMOLE-989: Implement keyboard lock menu item.

[GitBox <gi...@apache.org>]

necouchman commented on pull request #505:
URL: https://github.com/apache/guacamole-client/pull/505#issuecomment-903128206


   Okay, made one tweak, and I think I have it working. But, there are some caveats....
   
   Based on my testing of this feature (via https://keyboard-lock.glitch.me/), I see the following behavior:
   * Keyboard Lock only works when the browser is in full-screen mode.
   * Keyboard lock only captures keys that are fully passed through to the browser and not intercepted by the O/S. For example, in my testing on the above page:
   ** After activating keyboard lock, Alt-Tab was still intercepted by the O/S
   ** As mentioned on the page, Control-N and Control-T were not intercepted by the browser
   * Additionally, since the Escape key is used to exit Full Screen mode, it a) is not intercepted by Keyboard Lock, and b) results in the browser exiting Full Screen mode and turning off keyboard lock.
   
   So, I'm not really sure how valuable this feature is going to be for Guacamole Client. Maybe there are some key combinations that it will help with, but I find that most of these are already taken care of, at least in Chrome, by making the Guacamole page into a Chrome Application.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org