You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/04 12:53:06 UTC
[GitHub] [nuttx-apps] raiden00pl opened a new pull request, #1487: move embedlog from system to logging
raiden00pl opened a new pull request, #1487:
URL: https://github.com/apache/nuttx-apps/pull/1487
## Summary
move embedlog from apps/system to apps/logging
FYI @mlyszczek
## Impact
Breaking change for projects that use embedlog
## Testing
sim/nsh with examples/embedlog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] raiden00pl commented on pull request #1487: move embedlog from system to logging
Posted by GitBox <gi...@apache.org>.
raiden00pl commented on PR #1487:
URL: https://github.com/apache/nuttx-apps/pull/1487#issuecomment-1370919887
Kconfig definitions are changed, so project configuration files must be updated. I think it qualifies as 'breaking change' :]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] mlyszczek commented on pull request #1487: move embedlog from system to logging
Posted by GitBox <gi...@apache.org>.
mlyszczek commented on PR #1487:
URL: https://github.com/apache/nuttx-apps/pull/1487#issuecomment-1370907324
> Breaking change for projects that use embedlog
Why would this change break anything? Path of include file should not change in my opinion. It should stay in path as in `#include <embedlog.h>`. This is how it's on Linux and other Unices, and so should be the same on Nuttx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] mlyszczek commented on pull request #1487: move embedlog from system to logging
Posted by GitBox <gi...@apache.org>.
mlyszczek commented on PR #1487:
URL: https://github.com/apache/nuttx-apps/pull/1487#issuecomment-1370923772
This is minor I would say - you just have to change your own project. If include pathing is broken, this will be a bigger issue, as all out of tree project will have to include patch to change the path. Especially when project is built both on Linux (for testing) and Nuttx. If the change does not break `#include` then I say +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx-apps] xiaoxiang781216 merged pull request #1487: move embedlog from system to logging
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1487:
URL: https://github.com/apache/nuttx-apps/pull/1487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org