You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/07 07:54:30 UTC
[GitHub] [tvm] lmxyy opened a new pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
lmxyy opened a new pull request #8203:
URL: https://github.com/apache/tvm/pull/8203
Make query_rpc_tracker show the correct device server port and customized address. Previously, the `query_rpc_tracker` command shows a dummy port and does not support showing the customized address.
<img width="756" alt="image" src="https://user-images.githubusercontent.com/10475754/120979702-7073c300-c7a8-11eb-8094-1d1e5fd1aeb6.png">
Now, it shows the correct port and supports the customized address.
<img width="777" alt="image" src="https://user-images.githubusercontent.com/10475754/120979872-95683600-c7a8-11eb-9a32-f4b2ce2f596f.png">
Also fixed some minor typos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-857216135
@lmxyy ah i had missed the thing at your [first code pointer](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/tracker.py#L170).
could you change that line to `self._info = {}` then? there is no sense in recording the tracker connection's remote address in place of the RPC server that should be there. the "dummy" value you're referring to is the port dynamically allocated by the OS of the machine running the RPC server when the tracker connection is [established](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/server.py#L213).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch merged pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
areusch merged pull request #8203:
URL: https://github.com/apache/tvm/pull/8203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-856022619
@merrymercy @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on a change in pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on a change in pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#discussion_r647067531
##########
File path: python/tvm/exec/rpc_server.py
##########
@@ -78,7 +78,7 @@ def main(args):
and ROCM compilers.",
)
parser.add_argument(
- "--custom-addr", type=str, help="Custom IP Address to Report to RPC Tracker"
+ "--custom-addr", type=str, default=None, help="Custom IP Address to Report to RPC Tracker"
Review comment:
Yes, by default it is `None`. But I used to explicitly define it. I will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-857309156
Sure, I've changed `self._info={}`.
@tqchen Could you help review this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#discussion_r646767283
##########
File path: python/tvm/exec/rpc_server.py
##########
@@ -78,7 +78,7 @@ def main(args):
and ROCM compilers.",
)
parser.add_argument(
- "--custom-addr", type=str, help="Custom IP Address to Report to RPC Tracker"
+ "--custom-addr", type=str, default=None, help="Custom IP Address to Report to RPC Tracker"
Review comment:
i think `default=None` shouldn't be needed (it is the default)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-858208528
@tqchen @areusch @merrymercy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-856402725
> @lmxyy thanks for fixing this! I'm not quite sure I understand the order of events that leads to the incorrect port, though. could you explain for my understanding?
Sure. Previously, when you set up a server on your device side, the device would open a new connection to the tracker. When the tracker accepts the connection, it will register the device and record where the connection comes from ([code](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/tracker.py#L311-L312)). However, this connection is built on a dummy port on the device instead of the server port, so the address is not correct. Moreover, this address will not be updated since the device only sends the device key to the tracker ([code](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/server.py#L219)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] lmxyy commented on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
lmxyy commented on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-864565913
@areusch Do I need to make further modifications?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch edited a comment on pull request #8203: [Bug Fixed] Make query_rpc_tracker show the correct device server port and customized address
Posted by GitBox <gi...@apache.org>.
areusch edited a comment on pull request #8203:
URL: https://github.com/apache/tvm/pull/8203#issuecomment-857216135
@lmxyy ah i had missed the thing at your [first code pointer](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/tracker.py#L170).
could you change that line to `self._info = {}` then? there is no sense in recording the tracker connection's remote address in place of the RPC server that should be there. the "dummy" value you're referring to is the port dynamically allocated by the OS of the machine running the RPC server when the tracker connection is [established](https://github.com/apache/tvm/blob/64a8e81eeeefee0b11669dc83ee0d9ec871270f7/python/tvm/rpc/server.py#L213).
cc @tqchen in case he knows why we do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org