You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Apache Spark (Jira)" <ji...@apache.org> on 2021/03/24 07:33:00 UTC

[jira] [Commented] (SPARK-34853) Move partitioning and ordering to common limit trait

    [ https://issues.apache.org/jira/browse/SPARK-34853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17307614#comment-17307614 ] 

Apache Spark commented on SPARK-34853:
--------------------------------------

User 'c21' has created a pull request for this issue:
https://github.com/apache/spark/pull/31950

> Move partitioning and ordering to common limit trait
> ----------------------------------------------------
>
>                 Key: SPARK-34853
>                 URL: https://issues.apache.org/jira/browse/SPARK-34853
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.2.0
>            Reporter: Cheng Su
>            Priority: Trivial
>
> Both local limit and global limit define the output partitioning and output ordering in the same way and this is duplicated ([https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala#L159-L175] ). We can move the output partitioning and ordering into their parent trait - BaseLimitExec. This is a minor code refactoring.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org