You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rtexelm (via GitHub)" <gi...@apache.org> on 2023/11/06 22:52:31 UTC

[PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

rtexelm opened a new pull request, #25883:
URL: https://github.com/apache/superset/pull/25883

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Allow the size of the label to represent more of the filter title before truncation. Size changed from 60px to 96px
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   BEFORE:
   ![Previous size of label](https://github.com/apache/superset/assets/92495987/e561e8b9-181b-426d-8f84-4e075b1d5482)
   
   AFTER:
   ![New size of label](https://github.com/apache/superset/assets/92495987/8e9b2d3f-326a-492a-91c4-fa0febd33943)
   
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Create a filter with a title long enough to overflow 96px
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [X] Required feature flags: HORIZONTAL_FILTER_BAR
   - [X] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1815629057

   @kasiazjc, in light of @john-bodley's comment what do you think about us just removing the max-width on this element altogether. The filters do a pretty good job of adjusting their width on their own. Here's what it would look like with no max width on the label.
   
   https://github.com/apache/superset/assets/5186919/da49224a-6623-4355-908f-ac271c296e82
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1799349713

   Thanks @rtexelm for the PR. Isn't the readability a function of screen size and thus should the maximum width be a relative (as opposed to absolute) measure?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1802507686

   /testenv up FEATURE_HORIZONTAL_FILTER_BAR= True


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "kasiazjc (via GitHub)" <gi...@apache.org>.
kasiazjc commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1816642796

   > @kasiazjc, in light of @john-bodley's comment what do you think about us just removing the max-width on this element altogether. The filters do a pretty good job of adjusting their width on their own. Here's what it would look like with no max width on the label.
   > 
   >  Screen.Recording.2023-11-16.at.5.54.35.PM.mov
   
   I think removing max makes sense in this case, and good point @villebro about using description if needed. Let's do it :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1802513161

   @yousoph Ephemeral environment spinning up at http://35.87.101.189:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho merged PR #25883:
URL: https://github.com/apache/superset/pull/25883


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "rtexelm (via GitHub)" <gi...@apache.org>.
rtexelm commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1802512679

   @john-bodley Yes I think it should be relative, however I determined that would be a more significant style change that might be better suited to a separate PR after consulting with the designers while this was in response to a particular request for it to be set to 96px


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1819666931

   Ephemeral environment shutdown and build artifacts deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1799534965

   @eschutho Ephemeral environment spinning up at http://54.185.241.142:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1799531544

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1817239767

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/25883?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Comparison is base [(`d6fde3c`)](https://app.codecov.io/gh/apache/superset/commit/d6fde3cdd5987e3bf9a37d1fcde2dc82ef695747?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.00% compared to head [(`3396f4f`)](https://app.codecov.io/gh/apache/superset/pull/25883?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.00%.
   > Report is 48 commits behind head on master.
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #25883      +/-   ##
   ==========================================
   - Coverage   69.00%   69.00%   -0.01%     
   ==========================================
     Files        1938     1938              
     Lines       75831    75843      +12     
     Branches     8427     8427              
   ==========================================
   + Hits        52328    52332       +4     
   - Misses      21334    21341       +7     
   - Partials     2169     2170       +1     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/25883/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/25883/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.22% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/25883?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on code in PR #25883:
URL: https://github.com/apache/superset/pull/25883#discussion_r1397966506


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControl.tsx:
##########
@@ -49,7 +49,7 @@ const VerticalFilterControlTitle = styled.h4`
 const HorizontalFilterControlTitle = styled(VerticalFilterControlTitle)`
   font-weight: ${({ theme }) => theme.typography.weights.normal};
   color: ${({ theme }) => theme.colors.grayscale.base};
-  max-width: ${({ theme }) => theme.gridUnit * 15}px;
+  max-width: ${({ theme }) => theme.gridUnit * 24}px;

Review Comment:
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(horizontal filter bar filter labels): Increase max-width to 96px [superset]

Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on PR #25883:
URL: https://github.com/apache/superset/pull/25883#issuecomment-1815717189

   I tend to agree with @eschutho here. In my experience dashboard designers will usually tend to want the whole label to be visible, and if there's need for additional context that's not needed in the label, that can always be placed in the description to be displayed in the tooltip. So I vote for always showing the full label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org