You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org> on 2006/10/20 16:24:36 UTC

[jira] Created: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

t:stylesheet example renders two head elements (patch included)
---------------------------------------------------------------

                 Key: TOMAHAWK-749
                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Examples, Stylesheet
    Affects Versions: 1.1.5-SNAPSHOT
         Environment: Any
            Reporter: Jeff Bischoff
            Priority: Trivial
             Fix For: 1.1.5-SNAPSHOT


The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Cagatay Civici (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=all ]

Cagatay Civici updated TOMAHAWK-749:
------------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Examples, Stylesheet
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>         Assigned To: Cagatay Civici
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: css.jsp
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=comments#action_12450207 ] 
            
Jeff Bischoff commented on TOMAHAWK-749:
----------------------------------------

What steps can I take to help get these little fixes into the source code? Do I need to provide some sort of "diff" file, like CVS has? I assume SVN has something like this...

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Examples, Stylesheet
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: css.jsp
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=comments#action_12443852 ] 
            
Jeff Bischoff commented on TOMAHAWK-749:
----------------------------------------

I have attached a patch of css.jsp, from the Tomahawk examples webapp (simple).

The changes are:

* Commented out the incorrect inclusion of "head.inc"
* Added a comment explaining the change

I would not recommend simply removing the line altogether, as a well-meaning person might think it missing and add it back in again, in the future.

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Stylesheet, Examples
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: css.jsp
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Cagatay Civici (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=comments#action_12457138 ] 
            
Cagatay Civici commented on TOMAHAWK-749:
-----------------------------------------

Yes, svn patches as diffs would help more so we can directly apply the patch.

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Examples, Stylesheet
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>         Assigned To: Cagatay Civici
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: css.jsp
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=comments#action_12457377 ] 
            
Jeff Bischoff commented on TOMAHAWK-749:
----------------------------------------

Thanks Cagatay!

Next time I will submit a svn diff.

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Examples, Stylesheet
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>         Assigned To: Cagatay Civici
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>         Attachments: css.jsp
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (TOMAHAWK-749) t:stylesheet example renders two head elements (patch included)

Posted by "Jeff Bischoff (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/TOMAHAWK-749?page=all ]

Jeff Bischoff updated TOMAHAWK-749:
-----------------------------------

    Status: Patch Available  (was: Open)

> t:stylesheet example renders two head elements (patch included)
> ---------------------------------------------------------------
>
>                 Key: TOMAHAWK-749
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-749
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Stylesheet, Examples
>    Affects Versions: 1.1.5-SNAPSHOT
>         Environment: Any
>            Reporter: Jeff Bischoff
>            Priority: Trivial
>             Fix For: 1.1.5-SNAPSHOT
>
>
> The t:stylesheet example page (css.jsp) in the Tomahawk examples incorrectly renders two head elements for the generated html page. This is because the page both explicitly defines a head element and includes the standard tomahawk examples head element.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira