You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/02 04:23:47 UTC

[GitHub] [pulsar] coderzc commented on a diff in pull request #16887: [Fix][client-c++] Close `messages_` when PartitionedConsumer is closed.

coderzc commented on code in PR #16887:
URL: https://github.com/apache/pulsar/pull/16887#discussion_r935100906


##########
pulsar-client-cpp/lib/PartitionedConsumerImpl.cc:
##########
@@ -106,6 +106,9 @@ Result PartitionedConsumerImpl::receive(Message& msg, int timeout) {
         unAckedMessageTrackerPtr_->add(msg.getMessageId());
         return ResultOk;
     } else {
+        if (state_ != Ready) {
+            return ResultAlreadyClosed;
+        }

Review Comment:
   Thanks,I will fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org