You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/09/10 20:38:46 UTC

[GitHub] [ozone] myskov opened a new pull request, #3747: HDDS-7211 remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

myskov opened a new pull request, #3747:
URL: https://github.com/apache/ozone/pull/3747

   ## What changes were proposed in this pull request?
   
   This PR removes dead code from omKeyManagerImpl class. The most significant part of the removed code is helper methods of listStatusFSO(), which is unreachable and has been removed.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-7211
   
   ## How was this patch tested?
   
   Existing unit and integration tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3747:
URL: https://github.com/apache/ozone/pull/3747#issuecomment-1251228450

   @neils-dev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] myskov commented on pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
myskov commented on PR #3747:
URL: https://github.com/apache/ozone/pull/3747#issuecomment-1270020715

   since @aswinshakil hasn't been active for the last week, could you take a look at the PR please @kerneltime @adoroszlai ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] aswinshakil commented on pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
aswinshakil commented on PR #3747:
URL: https://github.com/apache/ozone/pull/3747#issuecomment-1259825205

   Thank you for working on this @myskov. I remember there was a plan to do a [cleanup](https://github.com/apache/ozone/pull/3444#discussion_r881710613) patch of `listStatusFSO()` after this [patch](https://github.com/apache/ozone/pull/3444) but wasn't done. I can approve it once the merge conflicts are resolved. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3747:
URL: https://github.com/apache/ozone/pull/3747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3747:
URL: https://github.com/apache/ozone/pull/3747#issuecomment-1270537197

   Thanks @myskov for the patch, @aswinshakil, @kerneltime for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] kerneltime commented on pull request #3747: HDDS-7211. remove dead code from org.apache.hadoop.ozone.omKeyManagerImpl

Posted by GitBox <gi...@apache.org>.
kerneltime commented on PR #3747:
URL: https://github.com/apache/ozone/pull/3747#issuecomment-1252624402

   I think there needs to be a couple of more reviewers to approve this PR, there is a lot of code that is being deleted (which is good) but we need to be sure that it won't be missed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org