You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/13 02:07:02 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #9517: [Build]
Add Github workflows
ktmud opened a new pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517
Recreating #9490 after some major refactoring.
### CATEGORY
- [x] Build / Development Environment
### SUMMARY
Adding GitHub Actions per discussion in #9481 . This is a pure addition to the current build process for now. Nothing changed for Travis CI, except Cypress was upgraded from `3.6.1` to `4.3.0`. We could evaluate whether to disable Travis CI once these GitHub Actions become more stable.
Jobs are split into 4 workflows to maximize parallelization:
- **superset-backend.yml:** python lint and unit tests
- **superset-frontend.yml:** frontend lint and unit tests
- **superset-e2e.yml:** end to end tests with Cypress
- **license-check.yml:** check license compatibility
A custom [GitHub Action](https://github.com/ktmud/cached-dependencies) was created to generalize the building steps related to caching and dependencies.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Once successfully integrated, GitHub PRs should have checks like below:
Meanwhile, use https://github.com/ktmud/incubator-superset/pull/27 to see these checks in action.
### TEST PLAN
Make sure CI passes.
### ADDITIONAL INFORMATION
N/A
### REVIEWERS
@john-bodley @dpgaspar @craig-rueda @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407517502
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
Also, make it an entity reference as to DRY things up. If you need to bust the cache later, this should simplify that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9517: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-612725498
@willbarrett @nytai This is ready for a final review. CI obviously [has passed](https://travis-ci.org/github/apache/incubator-superset/builds/674233888) but stuck at GitHub integration again.
At this point I feel we should just sign off the changes, force merge this and get rid of Travis already.
If you are interested, please review the reusable [Cached Dependencies](https://github.com/ktmud/cached-dependencies/pull/10/files) action, too. I extracted it into a separate repo and published in GitHub Marketplace so it can be used in other projects, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r409889654
##########
File path: .github/workflows/superset-python.yml
##########
@@ -0,0 +1,174 @@
+name: Python
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: apache-superset/cached-dependencies@ddf7d7f
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
Review comment:
Most of these commands are one liners so I wouldn't worry too much, but feel free to refactor if you could find a way to reuse `tox` commands without degrading the building speed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407385197
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -114,14 +109,9 @@ jobs:
REDIS_PORT: 16379
services:
mysql:
- image: mysql:5.7
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
This saves us another 10 seconds and now the full CI process can finish in under 7 minutes (when cached)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c343c2ff1d4c96dd9f532ee53e1b9cd1398ffb73&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
==========================================
- Coverage 58.78% 58.77% -0.02%
==========================================
Files 390 389 -1
Lines 12386 12370 -16
Branches 3073 3066 -7
==========================================
- Hits 7281 7270 -11
+ Misses 4921 4917 -4
+ Partials 184 183 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `42.85% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...nd/src/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=) | `13.79% <0.00%> (ø)` | |
| [...rc/explore/components/controls/AnnotationLayer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXIuanN4) | `2.36% <0.00%> (ø)` | |
| [superset-frontend/src/explore/validators.js](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvdmFsaWRhdG9ycy5qcw==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [c343c2f...38014ba](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407515944
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -0,0 +1,42 @@
+name: Frontend
+
+on:
+ push:
+ branches: [ master ]
+ paths:
+ - superset-frontend/src/*
Review comment:
Again, I'd just use the glob `superset-frontend/**` to be safe here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407342147
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
Review comment:
Really great to add `3.7` to the matrix, as it's fully functional. Once we have `3.7` in testing we can gradually start pushing `3.8`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407685074
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ postgres:
+ image: postgres:10-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: Initialize database
+ run: |
+ psql "postgresql://superset:superset@127.0.0.1:15432/superset" <<- EOF
+ DROP SCHEMA IF EXISTS sqllab_test_db;
+ CREATE SCHEMA sqllab_test_db;
+ DROP SCHEMA IF EXISTS admin_database;
+ CREATE SCHEMA admin_database;
+ EOF
+ - name: Python unit tests (PostgreSQL)
+ env:
+ SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ run: |
+ ./scripts/python_tests.sh
+
+ python-test-mysql:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ mysql:
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
I wouldn't sweat 10s. Also, although it's a drop-in replacement, it still makes sense to test with the real mccoy wherever possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9517: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613611245
Travis seem to be stuck forever again. The [test PR](https://github.com/ktmud/incubator-superset/pull/30) in my fork repo works great and have finished all checks in under 8 minutes.
I think I'm done with optimizing these workflows. Can we get this merged today? We can always iterate on it if we see any room for improvements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407341587
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
Review comment:
Wondering if we should pin this to `ubuntu-18.04` and bump periodically as new versions arrive?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407294837
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ postgres:
+ image: postgres:10.1-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ options: >-
+ --health-cmd pg_isready
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: Initialize database
+ run: |
+ psql "postgresql://superset:superset@127.0.0.1:15432/superset" <<- EOF
+ DROP SCHEMA IF EXISTS sqllab_test_db;
+ CREATE SCHEMA sqllab_test_db;
+ DROP SCHEMA IF EXISTS admin_database;
+ CREATE SCHEMA admin_database;
+ EOF
+ - name: Python unit tests (PostgreSQL)
+ env:
+ SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ run: |
+ ./scripts/python_tests.sh
+
+ python-test-mysql:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
Review comment:
Run `3.7` on PostgreSQL only to save resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 390 390
Lines 12386 12386
Branches 3073 3073
=======================================
Hits 7281 7281
Misses 4921 4921
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [f29d0fd...9b052f3](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407294837
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ postgres:
+ image: postgres:10.1-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ options: >-
+ --health-cmd pg_isready
+ --health-interval 10s
+ --health-timeout 5s
+ --health-retries 5
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: Initialize database
+ run: |
+ psql "postgresql://superset:superset@127.0.0.1:15432/superset" <<- EOF
+ DROP SCHEMA IF EXISTS sqllab_test_db;
+ CREATE SCHEMA sqllab_test_db;
+ DROP SCHEMA IF EXISTS admin_database;
+ CREATE SCHEMA admin_database;
+ EOF
+ - name: Python unit tests (PostgreSQL)
+ env:
+ SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ run: |
+ ./scripts/python_tests.sh
+
+ python-test-mysql:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
Review comment:
Run `3.7` only on PostgreSQL to save resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
==========================================
+ Coverage 58.57% 58.78% +0.21%
==========================================
Files 386 390 +4
Lines 12287 12386 +99
Branches 3025 3073 +48
==========================================
+ Hits 7197 7281 +84
- Misses 4906 4921 +15
Partials 184 184
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `85.71% <0.00%> (-5.96%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.00% <0.00%> (-3.89%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-0.61%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | `100.00% <0.00%> (ø)` | |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `91.30% <0.00%> (ø)` | |
| [...frontend/src/components/ListView/LegacyFilters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvTGVnYWN5RmlsdGVycy50c3g=) | `75.00% <0.00%> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `84.78% <0.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [a797465...67d4927](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407341671
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-latest
Review comment:
Same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407513709
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
Review comment:
These globs should be something like
```
- **/*.py # Catches all py changes
- superset/** # There might be changes to things like templates (or other non Py resources) that we still want to trigger on
- tests/**
- requirements*.txt
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407756004
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
Oof
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407644648
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ postgres:
+ image: postgres:10-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: Initialize database
+ run: |
+ psql "postgresql://superset:superset@127.0.0.1:15432/superset" <<- EOF
+ DROP SCHEMA IF EXISTS sqllab_test_db;
+ CREATE SCHEMA sqllab_test_db;
+ DROP SCHEMA IF EXISTS admin_database;
+ CREATE SCHEMA admin_database;
+ EOF
+ - name: Python unit tests (PostgreSQL)
+ env:
+ SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ run: |
+ ./scripts/python_tests.sh
+
+ python-test-mysql:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ mysql:
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
The image size is smaller. It saves about 10 seconds of download time. MariaDB 10.4 is a drop-in replacement to MySQL 5.7. But 10 seconds probably doesn't matter in the grand scheme of things.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #9517: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613670215
🚀 🚀 Thanks for merging this!
Can someone with admin access please also add a `CYPRESS_RECORD_KEY` secret [here](https://github.com/apache/incubator-superset/settings/secrets)?
You can use this token: 6f030d63-b2e9-426c-9544-7681a385d94c (will delete later)
or a token from the official Cypress organization account (then I'll update [revert the project id](https://github.com/apache/incubator-superset/pull/9517/files#diff-8b459551cb924dc591409f69e6371f6eL7) later).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r409881517
##########
File path: .github/workflows/superset-python.yml
##########
@@ -0,0 +1,174 @@
+name: Python
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: apache-superset/cached-dependencies@ddf7d7f
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
Review comment:
@craig-rueda and @ktmud apologies for chiming in late here but should we be invoking `tox` here rather than redefining the various CI commands?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407683929
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
See where these references are defined and then used later down the file:
https://github.com/apache/incubator-superset/blob/master/docker-compose.yml#L26
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407722511
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
Just spend an hour refactor an got this:
```
### ERRORED 21:06:58Z
- Your workflow file was invalid: The workflow is not valid. .github/workflows/superset-python.yml: Anchors are not currently supported. Remove the anchor 'python-job'
```
😞 Bummer!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407655048
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,66 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
Review comment:
We are going to remove it entirely. For now, yes, we should run unit tests in SQLite as the work to deprecate hasn't been started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9517: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a797465ae5b1f0064a0620d7511ec9bcffe8c1dc&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
==========================================
+ Coverage 58.57% 58.78% +0.21%
==========================================
Files 386 390 +4
Lines 12287 12386 +99
Branches 3025 3073 +48
==========================================
+ Hits 7197 7281 +84
- Misses 4906 4921 +15
Partials 184 184
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `85.71% <0.00%> (-5.96%)` | :arrow_down: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.00% <0.00%> (-3.89%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-0.61%)` | :arrow_down: |
| [superset-frontend/src/welcome/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/parseCookie.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3BhcnNlQ29va2llLnRz) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/utils/safeStringify.ts](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL3NhZmVTdHJpbmdpZnkudHM=) | `100.00% <0.00%> (ø)` | |
| [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==) | `91.30% <0.00%> (ø)` | |
| [superset-frontend/src/components/SearchInput.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VhcmNoSW5wdXQudHN4) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/components/StyledSelect.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU3R5bGVkU2VsZWN0LnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...erset-frontend/src/components/ListView/Filters.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvRmlsdGVycy50c3g=) | `84.78% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-superset/pull/9517/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [a797465...2b12a84](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407687327
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
Oh, so this is a feature in YAML. Didn't know you can do that. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407789342
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,91 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ FLASK_ENV: development
+ SUPERSET_CONFIG: tests.superset_test_config
+ SUPERSET__SQLALCHEMY_DATABASE_URI:
+ postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
+ postgres:
+ image: postgres:10-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: '3.6'
+
+ - name: Install dependencies
+ uses: apache-superset/cached-dependencies@1d9cb401cfac282356e990a15e98bf05faae1e91
+ with:
+ # Run commands in parallel does help initial installation without cache
+ parallel: true
+ run: |
+ npm-install && npm-build
+ pip-install && setup-postgres && testdata
+ cypress-install
+
+ - name: Cypress run all
+ env:
+ CYPRESS_GROUP: Default
+ CYPRESS_PATH: 'cypress/integration/*/*'
+ run: |
+ # Start Flask and run Cypress
+
+ # --no-debugger means disable the interactive debugger on the 500 page
+ # so errors can print to stderr.
+ flask run --no-debugger --with-threads -p 8081 &
+
+ sleep 3 # wait for the Flask app to start
+
+ cd ${{ github.workspace }}/superset-frontend/cypress-base/
+ npm run cypress -- run \
+ --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \
+ --record --group "${{ env.CYPRESS_GROUP }}" \
+ --ci-build-id ${{ github.event_name }}-${{ github.run_id }}
+
+ - name: Cypress run SQL Lab (with backend persist)
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config_sqllab_backend_persist
+ CYPRESS_GROUP: Backend persist
+ CYPRESS_PATH: 'cypress/integration/sqllab/*'
+ run: |
+ # Start Flask with alternative config and run Cypress
Review comment:
This test is actually not in Travis CI, but found in `tox.ini`. Adding it here because why not.
@betodealmeida could you confirm whether my change to [superset_test_config_sqllab_backend_persist.py](https://github.com/apache/incubator-superset/pull/9517/files#diff-8414ce7a93ecccde25c2e0b11acf44c6) is safe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407515566
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,66 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
Review comment:
We need a SQL server service in here (postgres?). SQLlite is being deprecated currently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407789342
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,91 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ FLASK_ENV: development
+ SUPERSET_CONFIG: tests.superset_test_config
+ SUPERSET__SQLALCHEMY_DATABASE_URI:
+ postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
+ postgres:
+ image: postgres:10-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: '3.6'
+
+ - name: Install dependencies
+ uses: apache-superset/cached-dependencies@1d9cb401cfac282356e990a15e98bf05faae1e91
+ with:
+ # Run commands in parallel does help initial installation without cache
+ parallel: true
+ run: |
+ npm-install && npm-build
+ pip-install && setup-postgres && testdata
+ cypress-install
+
+ - name: Cypress run all
+ env:
+ CYPRESS_GROUP: Default
+ CYPRESS_PATH: 'cypress/integration/*/*'
+ run: |
+ # Start Flask and run Cypress
+
+ # --no-debugger means disable the interactive debugger on the 500 page
+ # so errors can print to stderr.
+ flask run --no-debugger --with-threads -p 8081 &
+
+ sleep 3 # wait for the Flask app to start
+
+ cd ${{ github.workspace }}/superset-frontend/cypress-base/
+ npm run cypress -- run \
+ --browser ${{ matrix.browser }} --spec "${{ env.CYPRESS_PATH }}" \
+ --record --group "${{ env.CYPRESS_GROUP }}" \
+ --ci-build-id ${{ github.event_name }}-${{ github.run_id }}
+
+ - name: Cypress run SQL Lab (with backend persist)
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config_sqllab_backend_persist
+ CYPRESS_GROUP: Backend persist
+ CYPRESS_PATH: 'cypress/integration/sqllab/*'
+ run: |
+ # Start Flask with alternative config and run Cypress
Review comment:
This test is actually not in Travis CI, but found in `tox.ini`.
@betodealmeida could you confirm whether my change to [superset_test_config_sqllab_backend_persist.py](https://github.com/apache/incubator-superset/pull/9517/files#diff-8414ce7a93ecccde25c2e0b11acf44c6) is safe?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on issue #9517: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613670215
🚀 🚀 Thanks for merging this!
Can someone with admin access please also add a `CYPRESS_RECORD_KEY` secret [here](https://github.com/apache/incubator-superset/settings/secrets)?
Tracking the request here: https://issues.apache.org/jira/browse/INFRA-20119
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407604489
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,66 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
Review comment:
Should I add a section for unit tests in SQLite?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407372358
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,161 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-latest
Review comment:
All GitHub's official docs used `ubuntu-latest`, but I agree it's probably better to pin the version just to be safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 390 390
Lines 12386 12386
Branches 3073 3073
=======================================
Hits 7281 7281
Misses 4921 4921
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [f29d0fd...9b052f3](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407518393
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
+ - name: mypy
+ run: mypy $(echo $PYTHON_LINT_TARGET)
+ - name: isort
+ run: isort --check-only --recursive $(echo $PYTHON_LINT_TARGET)
+ - name: pylint
+ # `-j 0` run Pylint in parallel
+ run: pylint -j 0 superset
+
+ python-test-postgres:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ # run unit tests in multiple version just for fun
+ # (3.8 is not supported yet, some dependencies need an update)
+ python-version: [3.6, 3.7]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ postgres:
+ image: postgres:10-alpine
+ env:
+ POSTGRES_USER: superset
+ POSTGRES_PASSWORD: superset
+ ports:
+ - 15432:5432
+ redis:
+ image: redis:5-alpine
+ ports:
+ - 16379:6379
+ steps:
+ - uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
+ - name: Initialize database
+ run: |
+ psql "postgresql://superset:superset@127.0.0.1:15432/superset" <<- EOF
+ DROP SCHEMA IF EXISTS sqllab_test_db;
+ CREATE SCHEMA sqllab_test_db;
+ DROP SCHEMA IF EXISTS admin_database;
+ CREATE SCHEMA admin_database;
+ EOF
+ - name: Python unit tests (PostgreSQL)
+ env:
+ SUPERSET__SQLALCHEMY_DATABASE_URI: postgresql+psycopg2://superset:superset@127.0.0.1:15432/superset
+ run: |
+ ./scripts/python_tests.sh
+
+ python-test-mysql:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHONPATH: ${{ github.workspace }}
+ SUPERSET_CONFIG: tests.superset_test_config
+ REDIS_PORT: 16379
+ services:
+ mysql:
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
Any reason to use maria here and not the official mysql image? (https://hub.docker.com/_/mysql)
`yobasystems` seems a bit dubious :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull
request #9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407516854
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
can we name this something like `superset/cached-dependencies@v1`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407680719
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -0,0 +1,151 @@
+name: Backend
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - superset/**/*.py
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ python-lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Cache mypy
+ uses: actions/cache@v1
+ with:
+ path: .mypy_cache
+ key: ${{ runner.os }}-mypy-${{ hashFiles('./requirements*.txt') }}
+ restore-keys: |
+ ${{ runner.os }}-mypy-
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: ktmud/cached-dependencies@v1
Review comment:
Can you clarify on `entity reference`? I think I've optimized the cache setup as best as I can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 390 390
Lines 12386 12386
Branches 3073 3073
=======================================
Hits 7281 7281
Misses 4921 4921
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [f29d0fd...d0eb4e7](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9517: [Build] Add
Github workflows
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613666449
If @craig-rueda is comfortable with this, I propose we merge! 💯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on issue #9517: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613670215
🚀 🚀 Thanks for merging this!
Can someone with admin access please also add a `CYPRESS_RECORD_KEY` secret [here](https://github.com/apache/incubator-superset/settings/secrets)?
You can use this token: 6f030d63-b2e9-426c-9544-7681a385d94c (will delete later)
or a token from the official Cypress organization account (then I'll [revert the project id](https://github.com/apache/incubator-superset/pull/9517/files#diff-8b459551cb924dc591409f69e6371f6eL7) later).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407385197
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -114,14 +109,9 @@ jobs:
REDIS_PORT: 16379
services:
mysql:
- image: mysql:5.7
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
This saves us another 10 seconds and now the full CI process can finish in under 7 minutes (when cached)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #9517: [Build]
Add Github workflows
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407604489
##########
File path: .github/workflows/superset-e2e.yml
##########
@@ -0,0 +1,66 @@
+name: E2E
+
+on:
+ push:
+ branches: [ master ]
+ pull_request:
+
+jobs:
+ cypress:
+ name: Cypress
+ runs-on: ubuntu-18.04
+ strategy:
+ fail-fast: false
+ matrix:
+ browser: ['chrome']
+ env:
+ SUPERSET_CONFIG: tests.superset_test_config
+ PYTHONPATH: ${{ github.workspace }}
+ REDIS_PORT: 16379
+ CI: github-actions
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
+ services:
Review comment:
Is it just not recommended for end users or are we not going to support it at all? Should I add a section for unit tests in SQLite though?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r407385197
##########
File path: .github/workflows/superset-backend.yml
##########
@@ -114,14 +109,9 @@ jobs:
REDIS_PORT: 16379
services:
mysql:
- image: mysql:5.7
+ image: yobasystems/alpine-mariadb:10.4.12
Review comment:
This saves us another 10 seconds and now the full CI process can finish in under 7 minutes (with cache)!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 390 390
Lines 12386 12386
Branches 3073 3073
=======================================
Hits 7281 7281
Misses 4921 4921
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [f29d0fd...e50ad47](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request
#9517: [Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#discussion_r409887311
##########
File path: .github/workflows/superset-python.yml
##########
@@ -0,0 +1,174 @@
+name: Python
+
+on:
+ # only build on direct push to `master` branch
+ push:
+ branches: [ master ]
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - requirements*.txt
+ # but also build on pull requests to any branch
+ # (the so-called feature branch)
+ pull_request:
+ paths:
+ - ./**/*.py
+ - superset/**
+ - tests/**
+ - setup.py
+ - requirements*.txt
+
+jobs:
+ lint:
+ runs-on: ubuntu-18.04
+ strategy:
+ matrix:
+ python-version: [3.6]
+ env:
+ PYTHON_LINT_TARGET: setup.py superset tests
+ CI: github-actions
+ steps:
+ - name: Checkout code
+ uses: actions/checkout@v2
+ - name: Setup Python
+ uses: actions/setup-python@v1
+ with:
+ python-version: ${{ matrix.python-version }}
+ - name: Install dependencies
+ uses: apache-superset/cached-dependencies@ddf7d7f
+ - name: black
+ run: black --check $(echo $PYTHON_LINT_TARGET)
Review comment:
I didn't touch tox because I didn't want to interfere with Travis. Each tox env seems to be installing its own requirements, etc, which makes it harder to split steps and reuse caches like we did in the current GH Actions setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on issue #9517:
[Build] Add Github workflows
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9517: [Build] Add Github workflows
URL: https://github.com/apache/incubator-superset/pull/9517#issuecomment-613111924
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=h1) Report
> Merging [#9517](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f29d0fd9f2f93cf27e55475c61130518060d17fc&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9517 +/- ##
=======================================
Coverage 58.78% 58.78%
=======================================
Files 390 390
Lines 12386 12386
Branches 3073 3073
=======================================
Hits 7281 7281
Misses 4921 4921
Partials 184 184
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=footer). Last update [f29d0fd...89602dc](https://codecov.io/gh/apache/incubator-superset/pull/9517?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org