[GitHub] [incubator-superset] fbalicchia commented on a change in pull request #9346: improve helm chart

[GitBox <gi...@apache.org>]

fbalicchia commented on a change in pull request #9346: improve helm chart
URL: https://github.com/apache/incubator-superset/pull/9346#discussion_r399205927
 
 

 ##########
 File path: install/helm/superset/templates/deployment.yaml
 ##########
 @@ -42,6 +42,17 @@ spec:
           volumeMounts:
             - name: superset-config
               mountPath: /etc/superset/
+    {{- if .Values.supersetNode.hooks.postStart }}
+            - name: superset-config
+              mountPath: /superset_init.sh
+              subPath: superset_init.sh
+    {{- end }}
+          lifecycle:
+    {{- if .Values.supersetNode.hooks.postStart }}
+            postStart:
 
 Review comment:
   Thanks, Jobs in Kubernetes will run to completion once they are created. I' will make configurable enable/disable of init job and in the init containers of job image I'll wait for db Do you see any drawback ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org