You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David H. DeWolf" <da...@daviddewolf.com> on 2004/02/06 05:55:50 UTC

[PATCH] Maven: getting multiproject to work

Here is the diff of all of the changes necessary to make the 
multiproject goals work. Most of the changes were pretty minor.

Once implemented, users should no longer need to manually install the 
portlet-api-1.0.jar into thier repository.  Instead, the fullDeployment 
goal will run a multiproject:install which will recursivley go through 
all sub projects (including the portlet-api) and install them into the 
repository.

While I was at it, I also have modified a couple of other related things:

1) Smart copy of the pluto.xml context configuration file to tomcat.  
Now, the build only copies the file to the appropriate place -- based 
upon which version of tomcat you are using.  The goal WILL attempt to 
resolve which version you are using if you do not specify.

2)  Genericise (is that a word?) the tomcat deployment to remove some of 
the hard coded paths.  Dependencies, for instance,  can now be marked to 
be deployed to tomcat as a shared or common jar. 

3) Allow all "sub-project" documentation to be build with the 
multiproject:site goal.

4) Updated documents to show that we now depend on Maven 1.0-RC1 or greater.

I've tested all of these changes several times with a "clean" install of 
maven and tomcat 5.0.18, so I'm pretty sure that this will do the 
trick.  However, if there are any issues found, just let me know!  I've 
also tested once with tomcat4.x and believe that it works just as well.

David

Re: [PATCH] Maven: getting multiproject to work

Posted by Michael Blum <bl...@apache.org>.
Thank you David for implementing this with an impressive turnaround 
time. Great work!  I like all the changes.

Carsten thank you for your help too.

Michael


David H. DeWolf wrote:

> Great!  I'm glad you re-added the deploy goal, I inadvertently took it 
> out.
>
> I also should have mentioned:
>
> The property name for tomcat's home directory has changed. It's now:
> 'maven.tomcat.home'
>
> Additionally, there is a property 'maven.tomcat.version.major'.  This 
> lets you specify the major version of tomcat so that the build will 
> place the pluto.xml in the correct place.  If this is not set, the 
> tomcat goal will attempt to resolve it for you, however, I'm sure it's 
> resolution is not fool-proof (it simply look for the existence of 
> <TOMCAT_HOME>/conf/Catalina/admin.xml> and 
> <TOMCAT_HOME/webapps/admin.xml> and sets the version appropriately if 
> either is found).
>
> I made these property names more generic because as I was writing the 
> tomcat goals, I realized that deploying a webapp to tomcat is not 
> pluto specific.  Thus it seems like a maven tomcat plugin might be in 
> store, so I thought I'd make everything more generic in preparation 
> for that.
>
> David
>
> Carsten Ziegeler wrote:
>
>> Hi David,
>>
>> great work! Thanks!
>>
>> I will commit your patch, so we can all test it.
>>
>> In addition I readded the "deploy" goal that you can use to deploy
>> portlets.
>>
>> Many thanks David.
>>
>> Carsten
>>
>> David H. DeWolf wrote.
>>  
>>
>>> Here is the diff of all of the changes necessary to make the 
>>> multiproject goals work. Most of the changes were pretty minor.
>>>
>>> Once implemented, users should no longer need to manually install 
>>> the portlet-api-1.0.jar into thier repository.  Instead, the 
>>> fullDeployment goal will run a multiproject:install which will 
>>> recursivley go through all sub projects (including the portlet-api) 
>>> and install them into the repository.
>>>
>>> While I was at it, I also have modified a couple of other related 
>>> things:
>>>
>>> 1) Smart copy of the pluto.xml context configuration file to 
>>> tomcat.  Now, the build only copies the file to the appropriate 
>>> place -- based upon which version of tomcat you are using.  The goal 
>>> WILL attempt to resolve which version you are using if you do not 
>>> specify.
>>>
>>> 2)  Genericise (is that a word?) the tomcat deployment to remove 
>>> some of the hard coded paths.  Dependencies, for instance,  can now 
>>> be marked to be deployed to tomcat as a shared or common jar.
>>> 3) Allow all "sub-project" documentation to be build with the 
>>> multiproject:site goal.
>>>
>>> 4) Updated documents to show that we now depend on Maven 1.0-RC1 or 
>>> greater.
>>>
>>> I've tested all of these changes several times with a "clean" 
>>> install of maven and tomcat 5.0.18, so I'm pretty sure that this 
>>> will do the trick.  However, if there are any issues found, just let 
>>> me know!  I've also tested once with tomcat4.x and believe that it 
>>> works just as well.
>>>
>>> David
>>>
>>>   
>>
>>
>>  
>>
>
>
>
>


Re: [PATCH] Maven: getting multiproject to work

Posted by "David H. DeWolf" <da...@daviddewolf.com>.
Great!  I'm glad you re-added the deploy goal, I inadvertently took it out.

I also should have mentioned:

The property name for tomcat's home directory has changed. It's now:
'maven.tomcat.home'

Additionally, there is a property 'maven.tomcat.version.major'.  This 
lets you specify the major version of tomcat so that the build will 
place the pluto.xml in the correct place.  If this is not set, the 
tomcat goal will attempt to resolve it for you, however, I'm sure it's 
resolution is not fool-proof (it simply look for the existence of 
<TOMCAT_HOME>/conf/Catalina/admin.xml> and 
<TOMCAT_HOME/webapps/admin.xml> and sets the version appropriately if 
either is found).

I made these property names more generic because as I was writing the 
tomcat goals, I realized that deploying a webapp to tomcat is not pluto 
specific.  Thus it seems like a maven tomcat plugin might be in store, 
so I thought I'd make everything more generic in preparation for that.

David

Carsten Ziegeler wrote:

>Hi David,
>
>great work! Thanks!
>
>I will commit your patch, so we can all test it.
>
>In addition I readded the "deploy" goal that you can use to deploy
>portlets.
>
>Many thanks David.
>
>Carsten
>
>David H. DeWolf wrote.
>  
>
>>Here is the diff of all of the changes necessary to make the 
>>multiproject goals work. Most of the changes were pretty minor.
>>
>>Once implemented, users should no longer need to manually install the 
>>portlet-api-1.0.jar into thier repository.  Instead, the fullDeployment 
>>goal will run a multiproject:install which will recursivley go through 
>>all sub projects (including the portlet-api) and install them into the 
>>repository.
>>
>>While I was at it, I also have modified a couple of other related things:
>>
>>1) Smart copy of the pluto.xml context configuration file to tomcat.  
>>Now, the build only copies the file to the appropriate place -- based 
>>upon which version of tomcat you are using.  The goal WILL attempt to 
>>resolve which version you are using if you do not specify.
>>
>>2)  Genericise (is that a word?) the tomcat deployment to remove some of 
>>the hard coded paths.  Dependencies, for instance,  can now be marked to 
>>be deployed to tomcat as a shared or common jar. 
>>
>>3) Allow all "sub-project" documentation to be build with the 
>>multiproject:site goal.
>>
>>4) Updated documents to show that we now depend on Maven 1.0-RC1 
>>or greater.
>>
>>I've tested all of these changes several times with a "clean" install of 
>>maven and tomcat 5.0.18, so I'm pretty sure that this will do the 
>>trick.  However, if there are any issues found, just let me know!  I've 
>>also tested once with tomcat4.x and believe that it works just as well.
>>
>>David
>>
>>    
>>
>
>  
>



RE: [PATCH] Maven: getting multiproject to work

Posted by Carsten Ziegeler <cz...@s-und-n.de>.
Hi David,

great work! Thanks!

I will commit your patch, so we can all test it.

In addition I readded the "deploy" goal that you can use to deploy
portlets.

Many thanks David.

Carsten

David H. DeWolf wrote.
> 
> Here is the diff of all of the changes necessary to make the 
> multiproject goals work. Most of the changes were pretty minor.
> 
> Once implemented, users should no longer need to manually install the 
> portlet-api-1.0.jar into thier repository.  Instead, the fullDeployment 
> goal will run a multiproject:install which will recursivley go through 
> all sub projects (including the portlet-api) and install them into the 
> repository.
> 
> While I was at it, I also have modified a couple of other related things:
> 
> 1) Smart copy of the pluto.xml context configuration file to tomcat.  
> Now, the build only copies the file to the appropriate place -- based 
> upon which version of tomcat you are using.  The goal WILL attempt to 
> resolve which version you are using if you do not specify.
> 
> 2)  Genericise (is that a word?) the tomcat deployment to remove some of 
> the hard coded paths.  Dependencies, for instance,  can now be marked to 
> be deployed to tomcat as a shared or common jar. 
> 
> 3) Allow all "sub-project" documentation to be build with the 
> multiproject:site goal.
> 
> 4) Updated documents to show that we now depend on Maven 1.0-RC1 
> or greater.
> 
> I've tested all of these changes several times with a "clean" install of 
> maven and tomcat 5.0.18, so I'm pretty sure that this will do the 
> trick.  However, if there are any issues found, just let me know!  I've 
> also tested once with tomcat4.x and believe that it works just as well.
> 
> David
>