[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6768: Allow template names upto 255 chars

[GitBox <gi...@apache.org>]

rohityadavcloud commented on code in PR #6768:
URL: https://github.com/apache/cloudstack/pull/6768#discussion_r980213012


##########
server/src/main/java/com/cloud/template/TemplateManagerImpl.java:
##########
@@ -1747,7 +1747,7 @@ public VMTemplateVO createPrivateTemplateRecord(CreateTemplateCmd cmd, Account t
         _accountMgr.checkAccess(caller, null, true, templateOwner);
 
         String name = cmd.getTemplateName();
-        if ((name == null) || (name.length() > 32)) {
+        if ((name == null) || (name.length() > 255)) {
             throw new InvalidParameterValueException("Template name cannot be null and should be less than 32 characters");

Review Comment:
   Fix the error msg to say 255 characters too - otherwise LGTM (also check any limitation in the db column, VO etc)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org