[jira] [Commented] (ARTEMIS-406) STOMP acknowledgements should support transactions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407590#comment-16407590 ] 

ASF GitHub Bot commented on ARTEMIS-406:
----------------------------------------

GitHub user gaohoward opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1960

    ARTEMIS-406 STOMP acknowledgements should support transactions

    - Add support for transactional STOMP acks/nacks
    - Fixed some stomp test issues

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gaohoward/activemq-artemis a_a416

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1960
    
----

----


> STOMP acknowledgements should support transactions
> --------------------------------------------------
>
>                 Key: ARTEMIS-406
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-406
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: STOMP
>            Reporter: Lionel Cons
>            Assignee: Howard Gao
>            Priority: Major
>
> Artemis currently does not support transactional acknowledgements:
> {quote}
> Message acknowledgements are not transactional. The ACK frame can not be part of a transaction (it will be ignored if its transaction header is set).
> {quote}
> The STOMP 1.2 specification contains:
> {quote}
> Optionally, a transaction header MAY be specified, indicating that the message acknowledgment SHOULD be part of the named transaction.
> {quote}
> And other brokers (such as ActiveMQ 5.x) do support transactional acknowledgements.
> Artemis should support them too.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)