[jira] Commented: (SHINDIG-267) Write tests to exercise end-to-end RESTful server code

["Vasu Nori (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597180#action_12597180 ] 

Vasu Nori commented on SHINDIG-267:
-----------------------------------

Cassie

your patch looks good.
but I think this test could be a major nuisance for shindig developers because of the way Jetty is being run. RunJettyServer hardcodes the context path, abdera provider name, servlet name etc which are already declared in web.xml.
If anyone changes these params in web.xml, this test will fail and people will find it difficult to debug it. Until we figure out how to run Jetty correctly (by reading params from web.xml), I don't think we should check it in..


> Write tests to exercise end-to-end RESTful server code
> ------------------------------------------------------
>
>                 Key: SHINDIG-267
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-267
>             Project: Shindig
>          Issue Type: Improvement
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>         Attachments: fixLargeTests2.patch, patch.largetest
>
>
> RESTful server code path needs end-to-end tests to exercise as much code as possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.