[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #566: Make security context configurable.

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #566:
URL: https://github.com/apache/solr-operator/pull/566#discussion_r1193926400


##########
helm/solr-operator/README.md:
##########
@@ -182,6 +182,7 @@ The command removes all the Kubernetes components associated with the chart and
 | serviceAccount.name | string | `""` | If `serviceAccount.create` is set to `false`, the name of an existing serviceAccount in the target namespace **must** be provided to run the Solr Operator with. This serviceAccount with be given the operator's RBAC rules. |
 | resources.limits | map[string]string |  | Provide Resource limits for the Solr Operator container |
 | resources.requests | map[string]string |  | Provide Resource requests for the Solr Operator container |
+| securityContext | map[string]string | `allowPrivilegeEscalation: false, runAsNonRoot: true` | Provide security context for the Solr Operator container |

Review Comment:
   ```suggestion
   | securityContext | object | `allowPrivilegeEscalation: false, runAsNonRoot: true` | Provide security context for the Solr Operator container |
   ```
   
   the securityContext is an object, that can have values that aren't strings. So we shouldn't use `map[string]string` as the type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org