You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/03/10 22:47:10 UTC

[GitHub] [daffodil] tuxji commented on a change in pull request #770: Added dfdlx:alignmentViaSkip property

tuxji commented on a change in pull request #770:
URL: https://github.com/apache/daffodil/pull/770#discussion_r824235837



##########
File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/BitsCharset.scala
##########
@@ -55,7 +55,7 @@ trait BitsCharset extends Serializable {
   def aliases: Seq[String] = Nil
   def bitWidthOfACodeUnit: Int // in units of bits
   def requiredBitOrder: BitOrder
-  def mandatoryBitAlignment: Int
+  def mandatoryBitAlignment: Int // ignored when dfdlx:alignmentViaSkip is "yes"

Review comment:
       I agree, let's add a test to determine whether the diagnostic looks appropriate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org