[jira] [Created] (HDFS-3848) A Bug in recoverLeaseInternal method of FSNameSystem class

["Hooman Peiro Sajjad (JIRA)" <ji...@apache.org>]

Hooman Peiro Sajjad created HDFS-3848:
-----------------------------------------

             Summary: A Bug in recoverLeaseInternal method of FSNameSystem class
                 Key: HDFS-3848
                 URL: https://issues.apache.org/jira/browse/HDFS-3848
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: name-node
    Affects Versions: 0.23.1
            Reporter: Hooman Peiro Sajjad


This is a bug in logic of the method recoverLeaseInternal. In line 1322 it checks if the owner of the file is trying to recreate the file. The condition of the if statement is 

(leaseFile != null && leaseFile.equals(lease)) || lease.getHolder().equals(holder)

As it can be seen, there are two operands (conditions) connected with an "or" operator. The first operand is straight and will be true only if the holder of the file is the new holder. But the problem is the second operand which will be always true since the "lease" object is the one found by the "holder" by calling "Lease lease = leaseManager.getLease(holder);" in line 1315.

To fix this I think the if statement only should contain the following the condition:
(leaseFile != null && leaseFile.getHolder().equals(holder))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira