You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 10:46:58 UTC

[GitHub] [flink] WeiZhong94 opened a new pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

WeiZhong94 opened a new pull request #12167:
URL: https://github.com/apache/flink/pull/12167


   ## What is the purpose of the change
   
   *This pull request sets the working directory of the `ProcessBuilder` before running the Python helper scripts.*
   
   
   ## Brief change log
   
     - *Set the working directory of the `ProcessBuilder` before running the Python helper scripts.*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *pyflink e2e tests*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629563775


   @rmetzger @WeiZhong94 Thanks a lot. The tests have passed and so merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629169294


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 7e53be826522296276198784cad533977138ce21 (Fri May 15 10:52:14 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17724).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629272218


   Since this change is basically a fix to the currently broken master, I pushed it to my personal Azure to get a result sooner than Flink's CI: https://dev.azure.com/rmetzger/Flink/_build/results?buildId=8007&view=results


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629269589


   @flinkbot run azure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629169294


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60 (Fri Oct 16 10:31:07 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629179648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e53be826522296276198784cad533977138ce21",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420",
       "triggerID" : "7e53be826522296276198784cad533977138ce21",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e53be826522296276198784cad533977138ce21 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420) 
   * dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629179648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e53be826522296276198784cad533977138ce21",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420",
       "triggerID" : "7e53be826522296276198784cad533977138ce21",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1427",
       "triggerID" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e53be826522296276198784cad533977138ce21 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420) 
   * dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1427) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
dianfu commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629168032


   @WeiZhong94 Thanks for the PR. LGTM. Will merge once the tests passed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629179648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e53be826522296276198784cad533977138ce21",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420",
       "triggerID" : "7e53be826522296276198784cad533977138ce21",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1427",
       "triggerID" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1427) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] WeiZhong94 commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
WeiZhong94 commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629377660


   The python e2e test has passed in my Azure though the following test was canceled:
   https://dev.azure.com/weizhong0618/Flink/_build/results?buildId=103&view=logs&j=1f3ed471-1849-5d3c-a34c-19792af4ad16&t=2f5b54d0-1d28-5b01-d344-aa50ffe0cdf8
   See line 12143. May be this could help..


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629179648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e53be826522296276198784cad533977138ce21",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420",
       "triggerID" : "7e53be826522296276198784cad533977138ce21",
       "triggerType" : "PUSH"
     }, {
       "hash" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e53be826522296276198784cad533977138ce21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1420) 
   * dd0d6eddb6c7ae0ffa0920bc1771f7ecba7afe60 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12167:
URL: https://github.com/apache/flink/pull/12167#issuecomment-629179648


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7e53be826522296276198784cad533977138ce21",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7e53be826522296276198784cad533977138ce21",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7e53be826522296276198784cad533977138ce21 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] dianfu closed pull request #12167: [FLINK-17724][python] Set working directory before running the Python helper scripts.

Posted by GitBox <gi...@apache.org>.
dianfu closed pull request #12167:
URL: https://github.com/apache/flink/pull/12167


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org