You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by mi...@apache.org on 2019/12/27 11:33:20 UTC

[httpcomponents-client] branch master updated: [HTTPCLIENT-2041] AuthenticationStrategy#select() assumes challanges key to be lowercase

This is an automated email from the ASF dual-hosted git repository.

michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git


The following commit(s) were added to refs/heads/master by this push:
     new f71ee38  [HTTPCLIENT-2041] AuthenticationStrategy#select() assumes challanges key to be lowercase
f71ee38 is described below

commit f71ee388198c75bbe182d04efb126e97ea4a2d3b
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Fri Dec 27 12:31:53 2019 +0100

    [HTTPCLIENT-2041] AuthenticationStrategy#select() assumes challanges key to be lowercase
    
    Properly document that lowercase keys are required.
---
 .../main/java/org/apache/hc/client5/http/AuthenticationStrategy.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/httpclient5/src/main/java/org/apache/hc/client5/http/AuthenticationStrategy.java b/httpclient5/src/main/java/org/apache/hc/client5/http/AuthenticationStrategy.java
index 1e534a5..2dfb16f 100644
--- a/httpclient5/src/main/java/org/apache/hc/client5/http/AuthenticationStrategy.java
+++ b/httpclient5/src/main/java/org/apache/hc/client5/http/AuthenticationStrategy.java
@@ -54,7 +54,7 @@ public interface AuthenticationStrategy {
      * in their order of preference.
      *
      * @param challengeType challenge type.
-     * @param challenges collection of challenges.
+     * @param challenges map of challenges keyed by lowercase auth scheme names.
      * @param context HTTP context.
      * @return authentication auth schemes that can be used for authentication. Can be empty.
      *