You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/10/04 02:09:09 UTC

Re: [Apache Bloodhound] #427: Ticket delete buttons don't appear when tracopt.ticket.deleter is enabled

#427: Ticket delete buttons don't appear when tracopt.ticket.deleter is enabled
------------------------+-----------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  major      |  Milestone:  Release 9
 Component:  ui design  |    Version:
Resolution:             |   Keywords:
------------------------+-----------------------

Comment (by rjollos):

 In addition to trac:#11100, another problem is that `filter_stream` is
 matching for `ticket.html`, but `bh_ticket.html` is being filtered.
 Finally, we need to get the button styling correct, which involves another
 change to `tracopt.ticket.deleter`:

 {{{#!text/html
 <input class="trac-delete" type="submit" value="– Delete" title="Delete
 ticket">
 }}}
 ->
 {{{#!text/html
 <input class="trac-delete pull-right btn btn-mini" type="submit"
 value="Delete" title="Delete ticket">
 }}}

 This would lead to a nice styling of the buttons:

 [[Image(Buttons.png,100%)]]

 The latter change could be done with !JavaScript, however that doesn't
 resolve the problem of the `filter_stream` not being called until after
 the template is replaced in `post_process_request`.

 Perhaps the best solution here is to just implement adding of the button
 through JavaScript. That is what was proposed in
 trac:comment:1:ticket:11100.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/427#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker