You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 21:20:27 UTC
[GitHub] [airflow] Tofull opened a new pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Tofull opened a new pull request #13851:
URL: https://github.com/apache/airflow/pull/13851
`google_cloud_storage_conn_id` parameter has been deprecated by `GCSHook`, and should be replaced by `gcp_conn_id` parameter. `google_cloud_storage_conn_id` was still in use in many Operators.
`GCSHook` renders a `DeprecationWarning` message everytime one of those operators uses `google_cloud_storage_conn_id`.
This PR avoid triggering `DeprecationWarning` when using `GCSHook` in the codebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-766344059
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-766275593
[The Workflow run](https://github.com/apache/airflow/actions/runs/506613315) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-765706363
[The Workflow run](https://github.com/apache/airflow/actions/runs/504717876) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #13851:
URL: https://github.com/apache/airflow/pull/13851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-765690214
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-765706785
[The Workflow run](https://github.com/apache/airflow/actions/runs/504662492) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-766272434
I pushed fix for static check error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13851: replace `google_cloud_storage_conn_id` by `gcp_conn_id` when using `GCSHook`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13851:
URL: https://github.com/apache/airflow/pull/13851#issuecomment-765999962
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org