[Impala-ASF-CR] IMPALA-12631: Improve count star performance for parquet scans

["Zihao Ye (Code Review)" <ge...@cloudera.org>]

Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/20804 )

Change subject: IMPALA-12631: Improve count star performance for parquet scans
......................................................................


Patch Set 8:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20804/8/be/src/exec/parquet/hdfs-parquet-scanner.cc
File be/src/exec/parquet/hdfs-parquet-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/20804/8/be/src/exec/parquet/hdfs-parquet-scanner.cc@473
PS8, Line 473: dst_tuple
Is it okay if we don't update dst_tuple inside the loop? If there are multiple row groups, this could lead to incorrect results.


http://gerrit.cloudera.org:8080/#/c/20804/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

http://gerrit.cloudera.org:8080/#/c/20804/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1274
PS8, Line 1274: isFooterOnly
nit: This parameter seems unnecessary. Can't we do the same check (countStarSlot_ != null && analyzer.getQueryOptions().parquet_count_star_use_file_metadata) in transformBlocksToScanRanges()?



-- 
To view, visit http://gerrit.cloudera.org:8080/20804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9cd2448fe51a420d4559d0cc861c4d30822f4fd
Gerrit-Change-Number: 20804
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 04 Jan 2024 07:55:40 +0000
Gerrit-HasComments: Yes