You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/07/13 06:33:47 UTC
[GitHub] [carbondata] jackylk commented on a change in pull request #3324:
[HOTFIX] Fix task id in FileFormat write
jackylk commented on a change in pull request #3324: [HOTFIX] Fix task id in FileFormat write
URL: https://github.com/apache/carbondata/pull/3324#discussion_r303194100
##########
File path: integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
##########
@@ -143,6 +145,13 @@ class SparkCarbonFileFormat extends FileFormat
conf.set(CarbonSQLHadoopMapReduceCommitProtocol.COMMIT_PROTOCOL, "true")
new OutputWriterFactory {
+
+ /**
+ * counter used for generating unique task numbers.
+ */
+ val counter = new AtomicLong()
Review comment:
Can we use UUID instead of this shared variable to generate the id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services