You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "thomasrebele (via GitHub)" <gi...@apache.org> on 2025/11/13 20:15:34 UTC
[PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
thomasrebele opened a new pull request, #4632:
URL: https://github.com/apache/calcite/pull/4632
…h a non-simplifiable expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4632:
URL: https://github.com/apache/calcite/pull/4632#issuecomment-3529599348
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4632) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4632&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4632&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4632&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4632&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4632&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4632)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu merged PR #4632:
URL: https://github.com/apache/calcite/pull/4632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
Posted by "xiedeyantu (via GitHub)" <gi...@apache.org>.
xiedeyantu commented on code in PR #4632:
URL: https://github.com/apache/calcite/pull/4632#discussion_r2525414542
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -8634,7 +8491,7 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {
@Test void testExpandProjectInNullable() {
final String sql = "with e2 as (\n"
- + " select empno, case when true then deptno else null end as deptno\n"
+ + " select empno, case when deptno>0 then deptno else null end as deptno\n"
Review Comment:
```suggestion
+ " select empno, case when deptno > 0 then deptno else null end as deptno\n"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4632:
URL: https://github.com/apache/calcite/pull/4632#issuecomment-3531950103
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4632) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4632&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4632&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4632&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4632&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4632&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4632)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7292] Replace "case when true then deptno else null end" wit… [calcite]
Posted by "thomasrebele (via GitHub)" <gi...@apache.org>.
thomasrebele commented on code in PR #4632:
URL: https://github.com/apache/calcite/pull/4632#discussion_r2526795581
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -8634,7 +8491,7 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {
@Test void testExpandProjectInNullable() {
final String sql = "with e2 as (\n"
- + " select empno, case when true then deptno else null end as deptno\n"
+ + " select empno, case when deptno>0 then deptno else null end as deptno\n"
Review Comment:
I've changed all occurrences of `deptno>0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org